From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4E9041FF15F for ; Mon, 4 Nov 2024 13:24:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6D12B7E6; Mon, 4 Nov 2024 13:25:04 +0100 (CET) From: Timothy Nicholson To: pve-devel@lists.proxmox.com Date: Mon, 4 Nov 2024 13:24:57 +0100 Message-Id: <20241104122457.95494-1-t.nicholson@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH manager v2] fix #5810: ui: show confirmation/warning dialog for sdn apply X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This patch introduces a confirmation dialog for applying the SDN configuration. This is to warn the user that any pending network changes on the node level will also be applied. Signed-off-by: Timothy Nicholson --- As stated in the Bugzilla entry [1], the main purpose of this warning is to warn the user that any node network configuration changes will also be applied. A conditional warning that states whether any nodes have pending network changes (or even which nodes have changes) would definitely be nice, however this information is not readily available in the frontend, meaning there would need to be an API call for each node to find pending changes. I'll leave it open to discussion whether this would be worth it. [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=5810 changes since v1 [2]: - split into commit message and comment, thanks Lukas for the feedback. [2]: https://lore.proxmox.com/pve-devel/20241030120205.85845-1-t.nicholson@proxmox.com/ www/manager6/sdn/StatusView.js | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/www/manager6/sdn/StatusView.js b/www/manager6/sdn/StatusView.js index 970aa919..46ebe69a 100644 --- a/www/manager6/sdn/StatusView.js +++ b/www/manager6/sdn/StatusView.js @@ -41,14 +41,24 @@ Ext.define('PVE.sdn.StatusView', { { text: gettext('Apply'), handler: function() { - Proxmox.Utils.API2Request({ - url: '/cluster/sdn/', - method: 'PUT', - waitMsgTarget: me, - failure: function(response, opts) { - Ext.Msg.alert(gettext('Error'), response.htmlStatus); - }, - }); + Ext.Msg.show({ + title: gettext('Confirm'), + icon: Ext.Msg.WARNING, + msg: gettext('Any pending node network changes will also be applied. Proceed?'), + buttons: Ext.Msg.YESNO, + callback: function(btn) { + if (btn === 'yes') { + Proxmox.Utils.API2Request({ + url: '/cluster/sdn/', + method: 'PUT', + waitMsgTarget: me, + failure: function(response, opts) { + Ext.Msg.alert(gettext('Error'), response.htmlStatus); + }, + }); + } + } + }) }, }, ], -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel