From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6FAC81FF16B for ; Thu, 31 Oct 2024 14:47:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1D6CEAD0B; Thu, 31 Oct 2024 14:47:13 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Thu, 31 Oct 2024 14:46:26 +0100 Message-Id: <20241031134629.144893-1-d.kral@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/4] ui: api token: remove record context from TokenView add button handler X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Removes the record ("rec") variable from the TokenView, as it is always undefined, because the "Add" button is a ExtJS Button and therefore the button handler doesn't pass a third parameter as ProxmoxButton does. Signed-off-by: Daniel Kral --- Please correct me if I'm missing something here, but I tested this through Firefox's JavaScript debugger and assumed that tbar items are "ExtJS.button.Button" by default, except when specifing another xtype. This will make the fix for #5722 clearer to implement. www/manager6/dc/TokenView.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/www/manager6/dc/TokenView.js b/www/manager6/dc/TokenView.js index 69c60569..eb910feb 100644 --- a/www/manager6/dc/TokenView.js +++ b/www/manager6/dc/TokenView.js @@ -106,13 +106,11 @@ Ext.define('PVE.dc.TokenView', { { text: gettext('Add'), disabled: !caps.access['User.Modify'], - handler: function(btn, e, rec) { + handler: function(btn, e) { let data = {}; if (me.fixedUser) { data.userid = me.fixedUser; data.fixedUser = true; - } else if (rec && rec.data) { - data.userid = rec.data.userid; } let win = Ext.create('PVE.dc.TokenEdit', { isCreate: true, -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel