From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9365A1FF15C for ; Wed, 30 Oct 2024 10:59:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9B80613D7E; Wed, 30 Oct 2024 10:59:41 +0100 (CET) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Wed, 30 Oct 2024 10:59:24 +0100 Message-Id: <20241030095924.131300-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer] installer-common: do not drop nomodeset from target kernel cmdline X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" dropping the `nomodeset` here makes little sense: * currently users need to explicitly add it when booting the kernel, which is probably only done when the system needs it to show any output when booting * it was originally removed, because the installer had a grub-entry that explicitly disabled it - and the reasoning was to remove everything installer-specific - but I assume that it should cause less problems to keep it in place in all cases. This was also partially pointed to in: https://bugzilla.proxmox.com/show_bug.cgi?id=4230#c38 Fixes: a02a78a865fc37f7bdea077a4421319b84c635c9 Suggested-by: Thomas Lamprecht Signed-off-by: Stoiko Ivanov --- minimally tested by redoing the change in the second debug shell and installing in a VM w/ secure boot disabled (nomodeset breaks the debugshells if secureboot is enabled) one remaining question is if we want to also preserve the vga=\S+ parameter: * we set it for the TUI-installer options (to vga=788) - so this might warrant removal * while I assume that most cases where the TUI installer is used are either due to UX-preference, or to workaround issues with x.org - there might be cases where keeping it present ensures that the target system has a sensible/readabl console at all * if someone explicitly set it, it will get removed, so keeping all options apart from vga=788 might be a sensible improvment in any case will gladly send a follow-up for this Proxmox/Install/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Proxmox/Install/Config.pm b/Proxmox/Install/Config.pm index ae70093..49c247b 100644 --- a/Proxmox/Install/Config.pm +++ b/Proxmox/Install/Config.pm @@ -44,7 +44,7 @@ my sub parse_kernel_cmdline { } $cmdline =~ s/(?:BOOT_IMAGE|root|ramdisk_size|splash|vga)=\S+\s?//gi; - $cmdline =~ s/ro|rw|quiet|proxdebug|proxtui|nomodeset//gi; + $cmdline =~ s/ro|rw|quiet|proxdebug|proxtui//gi; $cfg->{target_cmdline}= $cmdline; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel