From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 17BC61FF166 for ; Fri, 25 Oct 2024 17:04:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8082C3211D; Fri, 25 Oct 2024 17:03:34 +0200 (CEST) From: Daniel Herzig To: pve-devel@lists.proxmox.com Date: Fri, 25 Oct 2024 17:02:42 +0200 Message-Id: <20241025150243.134466-12-d.herzig@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241025150243.134466-1-d.herzig@proxmox.com> References: <20241025150243.134466-1-d.herzig@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 11/12] fix #4225: ui: qemu: cdedit: enable required checkbox for isos X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Enables the 'required' checkbox for the IsoSelector. If the parameter is not set, the backend will use the default (set to 1). Behaviour: * Only send parameter if not default (required=0) * Checked if parameter is missing (default) * Unchecked when adding a new CD-ROM Signed-off-by: Daniel Herzig --- www/manager6/qemu/CDEdit.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js index 3cc16205..9f518f68 100644 --- a/www/manager6/qemu/CDEdit.js +++ b/www/manager6/qemu/CDEdit.js @@ -12,6 +12,7 @@ Ext.define('PVE.qemu.CDInputPanel', { me.drive.media = 'cdrom'; if (values.mediaType === 'iso') { me.drive.file = values.cdimage; + me.drive.required = values.required ? undefined : '0'; } else if (values.mediaType === 'cdrom') { me.drive.file = 'cdrom'; } else { @@ -44,6 +45,9 @@ Ext.define('PVE.qemu.CDInputPanel', { } else { values.mediaType = 'iso'; values.cdimage = drive.file; + if (drive.required === '1' || drive.required === undefined) { + values.required = '1'; + } } me.drive = drive; @@ -88,6 +92,7 @@ Ext.define('PVE.qemu.CDInputPanel', { cdImageField.validate(); } else { cdImageField.reset(); + delete me.drive.required; } }, }, @@ -98,6 +103,7 @@ Ext.define('PVE.qemu.CDInputPanel', { nodename: me.nodename, insideWizard: me.insideWizard, name: 'cdimage', + showRequired: true, }); items.push(me.isosel); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel