From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 381991FF164 for ; Wed, 23 Oct 2024 14:37:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9763D1E0A6; Wed, 23 Oct 2024 14:38:04 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Wed, 23 Oct 2024 14:37:22 +0200 Message-Id: <20241023123722.124478-7-d.kral@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023123722.124478-1-d.kral@proxmox.com> References: <20241023123722.124478-1-d.kral@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v3 6/6] fix #5430: ui: vm: allow editing cloudinit aio and cache options X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Adds cache and async I/O selectors to the CloudInit Drive Edit modal window in the "Hardware" tab. This allows users to set these options in the WebGUI when the VM fails to start because the underlying storage (driver) does not support a specific set of configurations. Signed-off-by: Daniel Kral --- www/manager6/qemu/CIDriveEdit.js | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/www/manager6/qemu/CIDriveEdit.js b/www/manager6/qemu/CIDriveEdit.js index d12124e8..40e493f2 100644 --- a/www/manager6/qemu/CIDriveEdit.js +++ b/www/manager6/qemu/CIDriveEdit.js @@ -18,6 +18,9 @@ Ext.define('PVE.qemu.CIDriveInputPanel', { me.drive.format = values.diskformat; } + PVE.Utils.propertyStringSet(me.drive, values.cache, 'cache'); + PVE.Utils.propertyStringSet(me.drive, values.aio, 'aio'); + params[confid] = PVE.Parser.printQemuDrive(me.drive); return params; @@ -49,6 +52,9 @@ Ext.define('PVE.qemu.CIDriveInputPanel', { } values.hdimage = drive.file; + values.cache = drive.cache || '__default__'; + values.aio = drive.aio || '__default__'; + me.drive = drive; me.setValues(values); @@ -81,6 +87,22 @@ Ext.define('PVE.qemu.CIDriveInputPanel', { me.items = items; + me.advancedColumnB = [ + { + xtype: 'CacheTypeSelector', + name: 'cache', + value: '__default__', + fieldLabel: gettext('Cache'), + }, + { + xtype: 'pveAsyncIoTypeSelector', + name: 'aio', + value: '__default__', + fieldLabel: gettext('Async IO'), + allowBlank: false, + }, + ]; + me.callParent(); }, }); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel