From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1843D1FF164 for ; Wed, 23 Oct 2024 14:36:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF6301DE66; Wed, 23 Oct 2024 14:37:33 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Wed, 23 Oct 2024 14:37:19 +0200 Message-Id: <20241023123722.124478-4-d.kral@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023123722.124478-1-d.kral@proxmox.com> References: <20241023123722.124478-1-d.kral@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v3 3/6] ui: vm: factor out async I/O type selector X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Factors out the combo box used for the Async I/O combo box selector, which is used in the Disk Edit modal window in the VM "Hardware" tab and the "Disks" tab in the Create Wizard, to reuse it in a future commit. Signed-off-by: Daniel Kral --- www/manager6/Makefile | 1 + www/manager6/form/AsyncIOTypeSelector.js | 10 ++++++++++ www/manager6/qemu/HDEdit.js | 10 ++-------- 3 files changed, 13 insertions(+), 8 deletions(-) create mode 100644 www/manager6/form/AsyncIOTypeSelector.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile index 2c3a822b..74a61aa8 100644 --- a/www/manager6/Makefile +++ b/www/manager6/Makefile @@ -21,6 +21,7 @@ JSSRC= \ form/ACMEAccountSelector.js \ form/ACMEPluginSelector.js \ form/AgentFeatureSelector.js \ + form/AsyncIOTypeSelector.js \ form/BackupCompressionSelector.js \ form/BackupModeSelector.js \ form/BandwidthSelector.js \ diff --git a/www/manager6/form/AsyncIOTypeSelector.js b/www/manager6/form/AsyncIOTypeSelector.js new file mode 100644 index 00000000..f36b0eb3 --- /dev/null +++ b/www/manager6/form/AsyncIOTypeSelector.js @@ -0,0 +1,10 @@ +Ext.define('PVE.form.AsyncIOTypeSelector', { + extend: 'Proxmox.form.KVComboBox', + alias: ['widget.pveAsyncIoTypeSelector'], + comboItems: [ + ['__default__', Proxmox.Utils.defaultText + ' (io_uring)'], + ['io_uring', 'io_uring'], + ['native', 'native'], + ['threads', 'threads'], + ], +}); diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index b78647ec..1c3f1b1d 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -306,17 +306,11 @@ Ext.define('PVE.qemu.HDInputPanel', { name: 'noreplicate', }, { - xtype: 'proxmoxKVComboBox', + xtype: 'pveAsyncIoTypeSelector', name: 'aio', + value: '__default__', fieldLabel: gettext('Async IO'), allowBlank: false, - value: '__default__', - comboItems: [ - ['__default__', Proxmox.Utils.defaultText + ' (io_uring)'], - ['io_uring', 'io_uring'], - ['native', 'native'], - ['threads', 'threads'], - ], }, ); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel