From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0F1791FF164 for ; Wed, 23 Oct 2024 13:22:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 701661C927; Wed, 23 Oct 2024 13:23:01 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Wed, 23 Oct 2024 13:22:45 +0200 Message-Id: <20241023112246.85637-6-d.kral@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023112246.85637-1-d.kral@proxmox.com> References: <20241023112246.85637-1-d.kral@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [me.drive, result.data] Subject: [pve-devel] [PATCH manager v2 5/6] ui: vm: make cloudinit drive editable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Implements the functionality to allow changes to the CloudInit drive under the VM "Hardware" tab after it has already been created by the user. Signed-off-by: Daniel Kral --- www/manager6/qemu/CIDriveEdit.js | 63 +++++++++++++++++++++++++------ www/manager6/qemu/HardwareView.js | 4 +- 2 files changed, 53 insertions(+), 14 deletions(-) diff --git a/www/manager6/qemu/CIDriveEdit.js b/www/manager6/qemu/CIDriveEdit.js index 006f9565..d12124e8 100644 --- a/www/manager6/qemu/CIDriveEdit.js +++ b/www/manager6/qemu/CIDriveEdit.js @@ -9,14 +9,16 @@ Ext.define('PVE.qemu.CIDriveInputPanel', { onGetValues: function(values) { let me = this; - let drive = {}; let params = {}; - let confid = values.controller + values.deviceid; + let confid = me.confid || values.controller + values.deviceid; - drive.file = values.hdstorage + ":cloudinit"; - drive.format = values.diskformat; + // only set these when we create cloudinit files + if (me.isCreate) { + me.drive.file = values.hdstorage + ":cloudinit"; + me.drive.format = values.diskformat; + } - params[confid] = PVE.Parser.printQemuDrive(drive); + params[confid] = PVE.Parser.printQemuDrive(me.drive); return params; }, @@ -31,7 +33,25 @@ Ext.define('PVE.qemu.CIDriveInputPanel', { setVMConfig: function(config) { let me = this; - me.busSelector.setVMConfig(config, 'cdrom'); + if (me.busSelector) { + me.busSelector.setVMConfig(config, 'cdrom'); + } + }, + + setDrive: function(drive) { + let me = this; + + let values = {}; + + let match = drive.file.match(/^([^:]+):/); + if (match) { + values.hdstorage = match[1]; + } + values.hdimage = drive.file; + + me.drive = drive; + + me.setValues(values); }, initComponent: function() { @@ -41,10 +61,12 @@ Ext.define('PVE.qemu.CIDriveInputPanel', { let items = []; - me.busSelector = Ext.create('PVE.form.ControllerSelector', { - withVirtIO: false, - fieldLabel: gettext('CloudInit Drive'), - }); + if (me.isCreate) { + me.busSelector = Ext.create('PVE.form.ControllerSelector', { + withVirtIO: false, + fieldLabel: gettext('CloudInit Drive'), + }); + } items.push(me.busSelector); items.push({ @@ -52,6 +74,8 @@ Ext.define('PVE.qemu.CIDriveInputPanel', { itemId: 'storselector', storageContent: 'images', nodename: me.nodename, + disabled: !me.isCreate, + hideFormat: !me.isCreate, hideSize: true, }); @@ -65,8 +89,6 @@ Ext.define('PVE.qemu.CIDriveEdit', { extend: 'Proxmox.window.Edit', xtype: 'pveCIDriveEdit', - isCreate: true, - initComponent: function() { let me = this; @@ -75,8 +97,12 @@ Ext.define('PVE.qemu.CIDriveEdit', { throw "no node name specified"; } + me.isCreate = !me.confid; + let ipanel = Ext.create('PVE.qemu.CIDriveInputPanel', { + confid: me.confid, nodename: nodename, + isCreate: me.isCreate, }); Ext.applyIf(me, { @@ -89,6 +115,19 @@ Ext.define('PVE.qemu.CIDriveEdit', { me.load({ success: function(response, opts) { ipanel.setVMConfig(response.result.data); + + if (me.confid) { + let value = response.result.data[me.confid]; + let drive = PVE.Parser.parseQemuDrive(me.confid, value); + + if (!drive) { + Ext.Msg.alert('Error', 'Unable to parse drive options'); + me.close(); + return; + } + + ipanel.setDrive(drive); + } }, }); }, diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 86d5f4cf..c7a77bd9 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6/qemu/HardwareView.js @@ -350,7 +350,7 @@ Ext.define('PVE.qemu.HardwareView', { if (rowdef.isOnStorageBus) { let value = me.getObjectValue(rec.data.key, '', true); if (isCloudInitKey(value)) { - return; + editor = 'PVE.qemu.CIDriveEdit'; } else if (value.match(/media=cdrom/)) { editor = 'PVE.qemu.CDEdit'; } else if (!diskCap) { @@ -629,7 +629,7 @@ Ext.define('PVE.qemu.HardwareView', { remove_btn.RESTMethod = isUnusedDisk || (isDisk && isRunning) ? 'POST' : 'PUT'; edit_btn.setDisabled( - deleted || !row.editor || isCloudInit || (isCDRom && !cdromCap) || (isDisk && !diskCap)); + deleted || !row.editor || (isCDRom && !cdromCap) || (isDisk && !diskCap)); diskaction_btn.setDisabled( pending || -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel