From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 959591FF164 for ; Wed, 23 Oct 2024 13:23:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 726461CB34; Wed, 23 Oct 2024 13:23:32 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Wed, 23 Oct 2024 13:22:44 +0200 Message-Id: <20241023112246.85637-5-d.kral@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241023112246.85637-1-d.kral@proxmox.com> References: <20241023112246.85637-1-d.kral@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [me.drive] Subject: [pve-devel] [PATCH manager v2 4/6] fix #5430: ui: vm: allow editing cdrom aio and cache options X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Adds cache and async I/O selectors to the CDROM Drive Edit modal in the "Hardware" tab. This allows users to set these options in the WebGUI when the VM fails to start because the underlying storage (driver) does not support a specific set of configurations. To accommodate the new fields in the modal, the total width is increased here, so that the fields' content is visible. Signed-off-by: Daniel Kral --- www/manager6/qemu/CDEdit.js | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js index d26d8631..3ed33a7c 100644 --- a/www/manager6/qemu/CDEdit.js +++ b/www/manager6/qemu/CDEdit.js @@ -19,6 +19,9 @@ Ext.define('PVE.qemu.CDInputPanel', { me.drive.file = 'none'; } + PVE.Utils.propertyStringSet(me.drive, values.cache, 'cache'); + PVE.Utils.propertyStringSet(me.drive, values.aio, 'aio'); + params[confid] = PVE.Parser.printQemuDrive(me.drive); return params; @@ -46,6 +49,9 @@ Ext.define('PVE.qemu.CDInputPanel', { values.cdimage = drive.file; } + values.cache = drive.cache || '__default__'; + values.aio = drive.aio || '__default__'; + me.drive = drive; me.setValues(values); @@ -118,6 +124,27 @@ Ext.define('PVE.qemu.CDInputPanel', { me.items = items; + // those are only useful for specific niche use cases + if (!me.insideWizard) { + me.advancedColumn1 = [ + { + xtype: 'CacheTypeSelector', + name: 'cache', + value: '__default__', + fieldLabel: gettext('Cache'), + }, + ]; + me.advancedColumn2 = [ + { + xtype: 'AsyncIOTypeSelector', + name: 'aio', + value: '__default__', + fieldLabel: gettext('Async IO'), + allowBlank: false, + }, + ]; + } + me.callParent(); }, }); @@ -125,7 +152,7 @@ Ext.define('PVE.qemu.CDInputPanel', { Ext.define('PVE.qemu.CDEdit', { extend: 'Proxmox.window.Edit', - width: 400, + width: 550, initComponent: function() { let me = this; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel