From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 20FCD1FF15D for ; Thu, 17 Oct 2024 13:51:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 676EBEA80; Thu, 17 Oct 2024 13:52:09 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Thu, 17 Oct 2024 13:51:24 +0200 Message-Id: <20241017115124.75539-4-d.kral@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241017115124.75539-1-d.kral@proxmox.com> References: <20241017115124.75539-1-d.kral@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 4/4] templates: add documentation to template_create X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Daniel Kral --- PVE/QemuServer.pm | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b26da505..114bafc5 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7794,7 +7794,17 @@ sub qga_check_running { return 1; } -sub template_create { +=head3 template_create($vmid, $conf [, $disk]) + +Converts all used disk volumes for the VM with the identifier C<$vmid> and +configuration C<$conf> to base images (e.g. for VM templates). + +If the optional C<$disk> parameter is set, it will only convert the disk +volume at the specified drive name (e.g. "scsi0"). + +=cut + +sub template_create : prototype($$;$) { my ($vmid, $conf, $disk) = @_; my $storecfg = PVE::Storage::config(); @@ -7811,6 +7821,8 @@ sub template_create { my $voliddst = PVE::Storage::vdisk_create_base($storecfg, $volid); $drive->{file} = $voliddst; $conf->{$ds} = print_drive($drive); + + # write vm config on every change in case this fails on subsequent iterations PVE::QemuConfig->write_config($vmid, $conf); }); } -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel