From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9115F1FF163 for ; Thu, 10 Oct 2024 17:57:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 919A31E155; Thu, 10 Oct 2024 17:57:01 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Thu, 10 Oct 2024 17:56:36 +0200 Message-Id: <20241010155650.255698-4-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241010155650.255698-1-s.hanreich@proxmox.com> References: <20241010155650.255698-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.259 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH proxmox-ve-rs v2 03/17] config: firewall: add tests for interface and directions X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Add tests for validating the directions in the guest firewall configuration. While I'm at it, I also added tests for validating interface names, since this functionality did not get tested before. Signed-off-by: Stefan Hanreich --- proxmox-ve-config/src/firewall/guest.rs | 53 +++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/proxmox-ve-config/src/firewall/guest.rs b/proxmox-ve-config/src/firewall/guest.rs index 1e70a67..23eaa4e 100644 --- a/proxmox-ve-config/src/firewall/guest.rs +++ b/proxmox-ve-config/src/firewall/guest.rs @@ -247,4 +247,57 @@ policy_forward: DROP } ); } + + #[test] + fn test_parse_valid_interface_prefix() { + const CONFIG: &str = r#" +[RULES] + +IN ACCEPT -p udp -dport 33 -sport 22 -log warning -i tapeth0 +"#; + + let config = CONFIG.as_bytes(); + let network_config: Vec = Vec::new(); + Config::parse(&Vmid::new(100), "tap", config, network_config.as_slice()).unwrap_err(); + } + + #[test] + fn test_parse_invalid_interface_prefix() { + const CONFIG: &str = r#" +[RULES] + +IN ACCEPT -p udp -dport 33 -sport 22 -log warning -i eth0 +"#; + + let config = CONFIG.as_bytes(); + let network_config: Vec = Vec::new(); + Config::parse(&Vmid::new(100), "tap", config, network_config.as_slice()).unwrap_err(); + } + + #[test] + fn test_parse_valid_directions() { + const CONFIG: &str = r#" +[RULES] + +IN ACCEPT -p udp -dport 33 -sport 22 -log warning +OUT ACCEPT -p udp -dport 33 -sport 22 -log warning +"#; + + let config = CONFIG.as_bytes(); + let network_config: Vec = Vec::new(); + Config::parse(&Vmid::new(100), "tap", config, network_config.as_slice()).unwrap(); + } + + #[test] + fn test_parse_invalid_direction() { + const CONFIG: &str = r#" +[RULES] + +FORWARD ACCEPT -p udp -dport 33 -sport 22 -log warning +"#; + + let config = CONFIG.as_bytes(); + let network_config: Vec = Vec::new(); + Config::parse(&Vmid::new(100), "tap", config, network_config.as_slice()).unwrap_err(); + } } -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel