From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A298C1FF15C for ; Wed, 2 Oct 2024 15:11:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E027FF711; Wed, 2 Oct 2024 15:12:02 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Wed, 2 Oct 2024 15:11:50 +0200 Message-Id: <20241002131157.227292-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [network.pm, tools.pm] Subject: [pve-devel] [PATCH common, widget-toolkit, manager v5 0/7] fix #3893: make bridge vids configurable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Since this version reworks a few things, especially in the logic, I dropped the r-b and t-b tags in some patches. The following patch has been dropped as this is handled in the API call itself now. [PATCH common v4 3/7] inotify: interfaces: make sure bridge_vids use space as separator There is now a new one (2/7) changing the check in the iNotify.pm file slightly. this version reworks a few parts since v4: incorporated @fionas suggestions, besides some style nits: * rename check_list_empty to list_is_empty and adapt the return values * renamed $check_vid to $valid_vid with return values for each case * switch list separators to spaces in the API call, instead of when writing the file * rework small logical error in the check if the end VLAN ID is larger than the start and $noerr is set. v3: incorporated @shannons recommendations, in detail: * improve regex with non-capturing group * reworked check if valid VLAN config in UI field check * small code style and spelling things * reworded UI explanation text for bridge vids v2: * renamed format in JSONSchema to a more generic `pve-vlan-id-or-range` * explicitly use spaces when writing interfaces file. This is one possible approach to deal with the fact, that the generic `-list` format will accept quite a few delimiters and we need spaces. * code style improvements such as naming the regex results. * add parameter verification to the web ui With the changes to the JSONSchema we can then work on using it too for the guest trunk option. This hasn't been started yet though. common: Aaron Lauterer (3): tools: add check_list_empty function inotify: interfaces: check if bridge_vids is truthy instead of defined fix #3893: network: add vlan id and range parameter definitions src/PVE/INotify.pm | 2 +- src/PVE/JSONSchema.pm | 39 +++++++++++++++++++++++++++++++++++++++ src/PVE/Tools.pm | 8 ++++++++ 3 files changed, 48 insertions(+), 1 deletion(-) widget-toolkit: Aaron Lauterer (2): fix #3892: Network: add bridge vids field for bridge_vids Network: add explanation for bridge vids field src/node/NetworkEdit.js | 73 +++++++++++++++++++++++++++++++++++++++++ src/node/NetworkView.js | 5 +++ 2 files changed, 78 insertions(+) manager: Aaron Lauterer (2): fix #3893: api: network: add bridge_vids parameter fix #3893: ui: network: enable bridge_vids field PVE/API2/Network.pm | 23 ++++++++++++++++++++++- www/manager6/node/Config.js | 1 + 2 files changed, 23 insertions(+), 1 deletion(-) -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel