From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A19F51FF15C for ; Wed, 2 Oct 2024 14:30:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F1EBCE94A; Wed, 2 Oct 2024 14:30:15 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 2 Oct 2024 14:27:21 +0200 Message-ID: <20241002122933.628461-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [utils.rs, options.rs, proxmox-auto-installer.rs, whatwg.org, lib.rs, main.rs, sys.pm] Subject: [pve-devel] [PATCH installer v2 0/7] use email regex from HTML spec for validation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This uses the regex for elements as defined in the HTML spec to validate emails in the installer. That regex should be a lot more robust than our current on and cover basically all cases of email addresses that might be encountered in the while. Also, patch #6 adds validation for the auto-installer `global.mailto` option too, while at it - which previously was not validated in any capacity. Patches #1 through #4 are just small cleanups/fixes and may be applied independently. [0] https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address history ======= Notable changes v1 -> v2: * rebased on current master diffstat ======== Christoph Heiss (7): cargo: convert `anyhow` to workspace dependency tui: fix new clippy lint auto-installer: drop some unneeded `pub` modifiers auto-installer: print full anyhow message on failure tui: use email regex from HTML specification for validation auto-installer: validate `global.mailto` answer option proxinstall: use email regex from HTML specification for validation Cargo.toml | 2 ++ Proxmox/Makefile | 1 + Proxmox/Sys.pm | 9 +++++++ proxinstall | 3 ++- proxmox-auto-install-assistant/Cargo.toml | 2 +- proxmox-auto-installer/Cargo.toml | 2 +- .../src/bin/proxmox-auto-installer.rs | 2 +- proxmox-auto-installer/src/utils.rs | 20 +++++++++------ proxmox-chroot/Cargo.toml | 2 +- proxmox-fetch-answer/Cargo.toml | 2 +- proxmox-installer-common/Cargo.toml | 1 + proxmox-installer-common/src/lib.rs | 3 +++ proxmox-installer-common/src/options.rs | 25 +++++++++++++++++++ proxmox-tui-installer/Cargo.toml | 1 - proxmox-tui-installer/src/main.rs | 22 ++++++---------- proxmox-tui-installer/src/options.rs | 3 ++- 16 files changed, 69 insertions(+), 31 deletions(-) create mode 100644 Proxmox/Sys.pm -- 2.44.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel