From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 658251FF15F for ; Mon, 9 Sep 2024 14:50:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 062F41316B; Mon, 9 Sep 2024 14:50:54 +0200 (CEST) From: Filip Schauer To: pve-devel@lists.proxmox.com Date: Mon, 9 Sep 2024 14:50:46 +0200 Message-Id: <20240909125047.47720-2-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240909125047.47720-1-f.schauer@proxmox.com> References: <20240909125047.47720-1-f.schauer@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH container v3 1/2] add deny-write option for device passthrough X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Add the deny-write options for device passthrough, to restrict container access to devices. Signed-off-by: Filip Schauer --- src/PVE/LXC.pm | 7 ++++++- src/PVE/LXC/Config.pm | 6 ++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 65d0fa8..cb24f2d 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -651,7 +651,12 @@ sub update_lxc_config { my $major = PVE::Tools::dev_t_major($rdev); my $minor = PVE::Tools::dev_t_minor($rdev); my $device_type_char = S_ISBLK($mode) ? 'b' : 'c'; - $raw .= "lxc.cgroup2.devices.allow = $device_type_char $major:$minor rw\n"; + my $allow_perms = "r" . $device->{'deny-write'} ? "" : "w"; + $raw .= "lxc.cgroup2.devices.allow = $device_type_char $major:$minor $allow_perms\n"; + + if ($device->{'deny-write'}) { + $raw .= "lxc.cgroup2.devices.deny = $device_type_char $major:$minor w\n"; + } }); # WARNING: DO NOT REMOVE this without making sure that loop device nodes diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 1664a35..ce64c4c 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -962,6 +962,12 @@ my $dev_desc = { minimum => 0, description => 'Group ID to be assigned to the device node', }, + 'deny-write' => { + optional => 1, + type => 'boolean', + description => 'Deny the container to write to the device', + default => 0, + }, }; for (my $i = 0; $i < $MAX_DEVICES; $i++) { -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel