From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B89C81FF161 for ; Tue, 27 Aug 2024 13:46:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4D69B322C6; Tue, 27 Aug 2024 13:46:50 +0200 (CEST) From: Filip Schauer To: pve-devel@lists.proxmox.com Date: Tue, 27 Aug 2024 13:46:43 +0200 Message-Id: <20240827114643.75506-1-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [tools.pm] Subject: [pve-devel] [PATCH container] fix #5666: fix quota regression due to device passthrough X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This commit fixes a regression introduced by commit ce1976b85361 ("Add device passthrough") Prior to the addition of device passthrough, the `lxc-pve-autodev-hook` would invoke `PVE::LXC::Tools::for_current_devices` only once. If the device list was empty, `exit 0` would be called and the `lxc-pve-autodev-hook` would exit. However, with the new device passthrough logic, when no devices were passed through, the `exit` call would be encountered prematurely. This would prevent the subsequent iteration over passthrough mounts from occurring. This commit resolves the issue by replacing the premature `exit` call with a `return` statement, ensuring the `lxc-pve-autodev-hook` continues executing and processes the passthrough mounts as expected. Signed-off-by: Filip Schauer --- src/PVE/LXC/Tools.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Tools.pm b/src/PVE/LXC/Tools.pm index 7e3e530..3380c62 100644 --- a/src/PVE/LXC/Tools.pm +++ b/src/PVE/LXC/Tools.pm @@ -89,7 +89,7 @@ sub for_devices { my $fd; if (! open $fd, '<', $devlist_file) { - exit 0 if $!{ENOENT}; # If the list is empty the file might not exist. + return if $!{ENOENT}; # If the list is empty the file might not exist. die "failed to open device list: $!\n"; } -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel