From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A5FD01FF15C for ; Wed, 21 Aug 2024 15:57:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0DC6A1B28F; Wed, 21 Aug 2024 15:58:00 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Wed, 21 Aug 2024 15:57:46 +0200 Message-Id: <20240821135748.146822-1-d.kral@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, esxiplugin.pm, vmx.rs] Subject: [pve-devel] [PATCH storage/esxi-import-tools 0/2] fix #5587: compatibility for flatcased 'filename' property in vmx file X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Compatibility for an older naming convention of the "fileName" property of mounted storage device images in vmx configuration files was requested at [1]. Previously, it was only possible to import ESXi VMs, where the mentioned property name was camelcased (e.g. "scsi0:0.fileName"). This patch allows this property name to also be flatcased for compatibility with older vmx versions (e.g. "scsi0:0.filename"). === I could reproduce the issue by creating an ESXi VM in ESXi 8.0.2 with the dialog and _manually_ renaming the property name to "filename". This caused the disk to not show up in PVE's Import Guest wizard. I could not reproduce the flatcased property name mentioned above by using the VMWare creation dialog alone, even when I tried to create a ESXi 4.x-compatible .vmx file (the oldest option available in VMvisor ESXi 8.0). === I tested the patch on two different PVE nodes (1 patched & 1 unpatched): 1. Creating two different ESXi VMs (Debian 6 and 12), 2. I imported them with the camelcased "fileName" successfully. 3. I changed the property name to "filename" in the vmx config files for both ESXi VMs and imported them on the patched PVE node successfully and could not import the disk image on the unpatched PVE node. 4. pve-storage passed all previous tests. [1] https://bugzilla.proxmox.com/show_bug.cgi?id=5587 storage: Daniel Kral (1): esxi: fix #5587: add support for older version of vmx storage filepaths src/PVE/Storage/ESXiPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) esxi-import-tools: Daniel Kral (1): fix #5587: add support for older version of vmx storage filepaths src/vmx.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel