From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B1C021FF16A for ; Wed, 14 Aug 2024 15:25:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 14A421E4C6; Wed, 14 Aug 2024 15:25:57 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 14 Aug 2024 15:25:39 +0200 Message-ID: <20240814132542.1315840-2-c.heiss@proxmox.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240814132542.1315840-1-c.heiss@proxmox.com> References: <20240814132542.1315840-1-c.heiss@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs] Subject: [pve-devel] [PATCH installer v5 1/3] tui: NumericEditView: add optional placeholder value X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Enables to add an optional placeholder value to `NumericEditView`, which will be displayed in a different (darker) color and not returned by `.get_content*()`. Can be used for having default values in the TUI, but with different handling in the back. Signed-off-by: Christoph Heiss --- Changes v4 -> v5: * no changes Changes v3 -> v4: * no changes Changes v2 -> v3: * when empty & focused, do not show the placeholder value at all Changes v1 -> v2: * new patch proxmox-tui-installer/src/views/mod.rs | 66 ++++++++++++++++++++++++-- 1 file changed, 62 insertions(+), 4 deletions(-) diff --git a/proxmox-tui-installer/src/views/mod.rs b/proxmox-tui-installer/src/views/mod.rs index a098d1f..c7491fc 100644 --- a/proxmox-tui-installer/src/views/mod.rs +++ b/proxmox-tui-installer/src/views/mod.rs @@ -2,9 +2,10 @@ use std::{net::IpAddr, rc::Rc, str::FromStr}; use cursive::{ event::{Event, EventResult}, + theme::BaseColor, view::{Resizable, ViewWrapper}, views::{EditView, LinearLayout, NamedView, ResizedView, SelectView, TextView}, - Rect, Vec2, View, + Printer, Rect, Vec2, View, }; use proxmox_installer_common::utils::CidrAddress; @@ -27,6 +28,7 @@ pub use timezone::*; pub struct NumericEditView { view: LinearLayout, max_value: Option, + placeholder: Option, max_content_width: Option, allow_empty: bool, } @@ -39,6 +41,7 @@ impl NumericEditView { Self { view, max_value: None, + placeholder: None, max_content_width: None, allow_empty: false, } @@ -57,6 +60,7 @@ impl NumericEditView { Self { view, max_value: None, + placeholder: None, max_content_width: None, allow_empty: false, } @@ -87,15 +91,42 @@ impl NumericEditView { self } + /// Sets a placeholder value for this view. Implies `allow_empty(true)`. + /// Implies `allow_empty(true)`. + /// + /// # Arguments + /// `placeholder` - The placeholder value to set for this view. + #[allow(unused)] + pub fn placeholder(mut self, placeholder: T) -> Self { + self.placeholder = Some(placeholder); + self.allow_empty(true) + } + + /// Returns the current value of the view. If a placeholder is defined and + /// no value is currently set, the placeholder value is returned. + /// + /// **This should only be called when `allow_empty = false` or a placeholder + /// is set.** pub fn get_content(&self) -> Result::Err> { - assert!(!self.allow_empty); - self.inner().get_content().parse() + let content = self.inner().get_content(); + + if content.is_empty() { + if let Some(placeholder) = self.placeholder { + return Ok(placeholder); + } + } + + assert!(!(self.allow_empty && self.placeholder.is_none())); + content.parse() } + /// Returns the current value of the view, or [`None`] if the view is + /// currently empty. pub fn get_content_maybe(&self) -> Option::Err>> { let content = self.inner().get_content(); + if !content.is_empty() { - Some(self.inner().get_content().parse()) + Some(content.parse()) } else { None } @@ -160,6 +191,25 @@ impl NumericEditView { std::mem::swap(self.inner_mut(), &mut inner); self } + + /// Generic `wrap_draw()` implementation for [`ViewWrapper`]. + /// + /// # Arguments + /// * `printer` - The [`Printer`] to draw to the base view. + fn wrap_draw_inner(&self, printer: &Printer) { + self.view.draw(printer); + + if self.inner().get_content().is_empty() && !printer.focused { + if let Some(placeholder) = self.placeholder { + let placeholder = placeholder.to_string(); + + printer.with_color( + (BaseColor::Blue.light(), BaseColor::Blue.dark()).into(), + |printer| printer.print((0, 0), &placeholder), + ); + } + } + } } pub type FloatEditView = NumericEditView; @@ -168,6 +218,10 @@ pub type IntegerEditView = NumericEditView; impl ViewWrapper for FloatEditView { cursive::wrap_impl!(self.view: LinearLayout); + fn wrap_draw(&self, printer: &Printer) { + self.wrap_draw_inner(printer); + } + fn wrap_on_event(&mut self, event: Event) -> EventResult { let original = self.inner_mut().get_content(); @@ -207,6 +261,10 @@ impl FloatEditView { impl ViewWrapper for IntegerEditView { cursive::wrap_impl!(self.view: LinearLayout); + fn wrap_draw(&self, printer: &Printer) { + self.wrap_draw_inner(printer); + } + fn wrap_on_event(&mut self, event: Event) -> EventResult { let original = self.inner_mut().get_content(); -- 2.45.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel