From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7068C1FF177 for ; Fri, 2 Aug 2024 15:28:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 22A8DDD80; Fri, 2 Aug 2024 15:27:59 +0200 (CEST) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Fri, 2 Aug 2024 15:26:44 +0200 Message-Id: <20240802132656.270077-7-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240802132656.270077-1-m.carrara@proxmox.com> References: <20240802132656.270077-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v1 pve-common 06/18] pbsclient: use spaces around list braces and parens around ternaries X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Max Carrara --- src/PVE/PBSClient.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm index d707971..d3daf41 100644 --- a/src/PVE/PBSClient.pm +++ b/src/PVE/PBSClient.pm @@ -216,7 +216,7 @@ my sub run_client_cmd : prototype($$;$$$$) { $param = [] if !defined($param); $param = [ $param ] if !ref($param); - $param = [@$param, '--output-format=json'] if !$no_output; + $param = [ @$param, '--output-format=json' ] if !$no_output; do_raw_client_cmd( $self, @@ -239,7 +239,7 @@ sub autogen_encryption_key { my ($self) = @_; my $encfile = $self->encryption_key_file_name(); run_command( - ['proxmox-backup-client', 'key', 'create', '--kdf', 'none', $encfile], + [ 'proxmox-backup-client', 'key', 'create', '--kdf', 'none', $encfile ], errmsg => 'failed to create encryption key' ); return file_get_contents($encfile); @@ -327,7 +327,7 @@ sub forget_snapshot { (my $namespace, $snapshot) = split_namespaced_parameter($self, $snapshot); - return run_client_cmd($self, 'forget', ["$snapshot"], 1, undef, $namespace) + return run_client_cmd($self, 'forget', [ "$snapshot" ], 1, undef, $namespace) }; sub prune_group { @@ -383,7 +383,7 @@ sub file_restore_list { my ($self, $snapshot, $filepath, $base64, $extra_params) = @_; (my $namespace, $snapshot) = split_namespaced_parameter($self, $snapshot); - my $cmd = [ $snapshot, $filepath, "--base64", $base64 ? 1 : 0]; + my $cmd = [ $snapshot, $filepath, "--base64", ($base64 ? 1 : 0) ]; if (my $timeout = $extra_params->{timeout}) { push($cmd->@*, '--timeout', $timeout); @@ -435,7 +435,7 @@ sub file_restore_extract { my $fn = fileno($fh); my $errfunc = sub { print $_[0], "\n"; }; - my $cmd = [ $snapshot, $filepath, "-", "--base64", $base64 ? 1 : 0]; + my $cmd = [ $snapshot, $filepath, "-", "--base64", ($base64 ? 1 : 0) ]; if ($tar) { push(@$cmd, '--format', 'tar', '--zstd', 1); } -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel