From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E1A951FF177 for ; Fri, 2 Aug 2024 15:27:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1A211DA4C; Fri, 2 Aug 2024 15:27:14 +0200 (CEST) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Fri, 2 Aug 2024 15:26:41 +0200 Message-Id: <20240802132656.270077-4-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240802132656.270077-1-m.carrara@proxmox.com> References: <20240802132656.270077-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v1 pve-common 03/18] pbsclient: use post-if definedness checks instead of '//=' operator X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Max Carrara --- src/PVE/PBSClient.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm index 3e98dd1..525b37f 100644 --- a/src/PVE/PBSClient.pm +++ b/src/PVE/PBSClient.pm @@ -208,7 +208,7 @@ my sub run_client_cmd : prototype($$;$$$$) { my $json_str = ''; my $outfunc = sub { $json_str .= "$_[0]\n" }; - $binary //= 'proxmox-backup-client'; + $binary = 'proxmox-backup-client' if !defined($binary); $param = [] if !defined($param); $param = [ $param ] if !ref($param); @@ -286,7 +286,7 @@ sub backup_fs_tree { '--backup-id', $id, ]; - $cmd_opts //= {}; + $cmd_opts = {} if !defined($cmd_opts); $cmd_opts->{namespace} = $self->{scfg}->{namespace} if defined($self->{scfg}->{namespace}); @@ -308,7 +308,7 @@ sub restore_pxar { "$target", "--allow-existing-dirs", 0, ]; - $cmd_opts //= {}; + $cmd_opts = {} if !defined($cmd_opts); $cmd_opts->{namespace} = $namespace; -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel