From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3F8CF1FF177 for ; Fri, 2 Aug 2024 15:28:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6EDF3DFCB; Fri, 2 Aug 2024 15:28:45 +0200 (CEST) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Fri, 2 Aug 2024 15:26:53 +0200 Message-Id: <20240802132656.270077-16-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240802132656.270077-1-m.carrara@proxmox.com> References: <20240802132656.270077-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v1 pve-common 15/18] pbsclient: don't return anything in PXAR methods X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Due to the previously removed implicit return in `do_raw_client_cmd`, the `run_raw_client_cmd` and consequently also the `backup_fs_tree` and `restore_pxar` methods would return `0` on success if they didn't `die` otherwise. Therefore, because now nothing is actually returned, explicitly don't return anything in order to prevent returning something implicitly in the future (if e.g. `run_raw_client_cmd` is made to return something). Signed-off-by: Max Carrara --- src/PVE/PBSClient.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm index 4ffdd04..4adb04c 100644 --- a/src/PVE/PBSClient.pm +++ b/src/PVE/PBSClient.pm @@ -605,7 +605,8 @@ sub backup_fs_tree { $cmd_opts->{namespace} = $namespace; } - return run_raw_client_cmd($self, 'backup', $param, %$cmd_opts); + run_raw_client_cmd($self, 'backup', $param, %$cmd_opts); + return; }; =pod @@ -653,7 +654,8 @@ sub restore_pxar { $cmd_opts->{namespace} = $namespace; - return run_raw_client_cmd($self, 'restore', $param, %$cmd_opts); + run_raw_client_cmd($self, 'restore', $param, %$cmd_opts); + return; }; =pod -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel