From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 01EC71FF177 for ; Fri, 2 Aug 2024 15:28:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 655C4DDD7; Fri, 2 Aug 2024 15:28:10 +0200 (CEST) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Fri, 2 Aug 2024 15:26:52 +0200 Message-Id: <20240802132656.270077-15-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240802132656.270077-1-m.carrara@proxmox.com> References: <20240802132656.270077-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v1 pve-common 14/18] pbsclient: prohibit implicit return X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" .. for the `set_password`, `set_encryption_key` and `do_raw_client_cmd` methods. This makes it very clear that these methods aren't supposed to return anything. In the case of `do_raw_client_cmd` in particular, the implicit return of `0` on success (would be `undef` if the command failed) was never depended on either, so prevent future code from doing so. Signed-off-by: Max Carrara --- src/PVE/PBSClient.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm index a701542..4ffdd04 100644 --- a/src/PVE/PBSClient.pm +++ b/src/PVE/PBSClient.pm @@ -223,6 +223,7 @@ sub set_password { }); PVE::Tools::file_set_contents($pwfile, "$password\n", 0600); + return; }; =pod @@ -309,6 +310,7 @@ sub set_encryption_key { }); PVE::Tools::file_set_contents($encfile, "$key\n", 0600); + return; }; =pod @@ -416,6 +418,7 @@ my sub do_raw_client_cmd { } run_command($cmd, %opts); + return; } my sub run_raw_client_cmd : prototype($$$%) { -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel