From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E8EED1FF16E for ; Mon, 29 Jul 2024 13:55:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6F8971C158; Mon, 29 Jul 2024 13:55:44 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 29 Jul 2024 13:55:34 +0200 Message-Id: <20240729115540.191594-2-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240729115540.191594-1-a.lauterer@proxmox.com> References: <20240729115540.191594-1-a.lauterer@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH common v4 1/7] tools: add check_list_empty function X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" In some situations we don't want a total empty list. I opted for a dedicated function instead of integrating it as error in the `split_list` function. It is used in many places and the potential fallout from unintended behavior changes is too big. Signed-off-by: Aaron Lauterer Tested-By: Stefan Hanreich Reviewed-by: Shannon Sterz --- changes since: v3: none v2: newly added src/PVE/Tools.pm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index bd305bd..f796bd0 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -718,6 +718,14 @@ sub split_list { return @data; } +sub check_list_empty { + my ($list) = @_; + if (scalar(PVE::Tools::split_list($list)) < 1) { + return 0; + } + return 1; +} + sub trim { my $txt = shift; -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel