From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 89A4A1FF15C for ; Wed, 24 Jul 2024 19:19:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2C2971FD0D; Wed, 24 Jul 2024 19:19:36 +0200 (CEST) From: Filip Schauer To: pve-devel@lists.proxmox.com Date: Wed, 24 Jul 2024 19:18:56 +0200 Message-Id: <20240724171857.432913-2-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240724171857.432913-1-f.schauer@proxmox.com> References: <20240724171857.432913-1-f.schauer@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm, lxc.pm] Subject: [pve-devel] [PATCH container v2 1/2] add deny read/write options for device passthrough X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Add the deny_read and deny_write options for device passthrough, to restrict container access to devices. Signed-off-by: Filip Schauer --- src/PVE/LXC.pm | 13 ++++++++++++- src/PVE/LXC/Config.pm | 12 ++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 65d0fa8..6e2b048 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -651,7 +651,18 @@ sub update_lxc_config { my $major = PVE::Tools::dev_t_major($rdev); my $minor = PVE::Tools::dev_t_minor($rdev); my $device_type_char = S_ISBLK($mode) ? 'b' : 'c'; - $raw .= "lxc.cgroup2.devices.allow = $device_type_char $major:$minor rw\n"; + my $allow_perms = $device->{deny_read} ? "" : "r"; + my $deny_perms = $device->{deny_read} ? "r" : ""; + $allow_perms .= $device->{deny_write} ? "" : "w"; + $deny_perms .= $device->{deny_write} ? "w" : ""; + + if ($allow_perms) { + $raw .= "lxc.cgroup2.devices.allow = $device_type_char $major:$minor $allow_perms\n"; + } + + if ($deny_perms) { + $raw .= "lxc.cgroup2.devices.deny = $device_type_char $major:$minor $deny_perms\n"; + } }); # WARNING: DO NOT REMOVE this without making sure that loop device nodes diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 1664a35..b37f84d 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -962,6 +962,18 @@ my $dev_desc = { minimum => 0, description => 'Group ID to be assigned to the device node', }, + deny_read => { + optional => 1, + type => 'boolean', + description => 'Deny the container to read from the device', + default => 0, + }, + deny_write => { + optional => 1, + type => 'boolean', + description => 'Deny the container to write to the device', + default => 0, + }, }; for (my $i = 0; $i < $MAX_DEVICES; $i++) { -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel