From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2D0621FF2CA for ; Tue, 23 Jul 2024 17:25:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04BA76821; Tue, 23 Jul 2024 17:25:57 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 23 Jul 2024 17:25:44 +0200 Message-Id: <20240723152548.129832-7-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240723152548.129832-1-f.ebner@proxmox.com> References: <20240723152548.129832-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server 06/10] cfg2cmd: require at least QEMU binary version 5.0 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The minimum supported version for a Proxmox VE 8 node is QEMU 8.0. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 4 ++-- test/cfg2cmd/old-qemu.conf | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 75995366..39b33438 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3554,9 +3554,9 @@ sub config_to_command { my $kvm_binary = get_command_for_arch($arch); my $kvmver = kvm_user_version($kvm_binary); - if (!$kvmver || $kvmver !~ m/^(\d+)\.(\d+)/ || $1 < 4) { + if (!$kvmver || $kvmver !~ m/^(\d+)\.(\d+)/ || $1 < 5) { $kvmver //= "undefined"; - die "Detected old QEMU binary ('$kvmver', at least 4.0 is required)\n"; + die "Detected old QEMU binary ('$kvmver', at least 5.0 is required)\n"; } my $add_pve_version = min_version($kvmver, 4, 1); diff --git a/test/cfg2cmd/old-qemu.conf b/test/cfg2cmd/old-qemu.conf index 14489a3b..e8129cf6 100644 --- a/test/cfg2cmd/old-qemu.conf +++ b/test/cfg2cmd/old-qemu.conf @@ -1,4 +1,4 @@ # TEST: Test QEMU version detection and expect fail on old version -# QEMU_VERSION: 3.0.1 -# EXPECT_ERROR: Detected old QEMU binary ('3.0.1', at least 4.0 is required) +# QEMU_VERSION: 4.0.1 +# EXPECT_ERROR: Detected old QEMU binary ('4.0.1', at least 5.0 is required) smbios1: uuid=7b10d7af-b932-4c66-b2c3-3996152ec465 -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel