From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4F7371FF2CA for ; Tue, 23 Jul 2024 17:25:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BEBDC6738; Tue, 23 Jul 2024 17:26:00 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 23 Jul 2024 17:25:39 +0200 Message-Id: <20240723152548.129832-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240723152548.129832-1-f.ebner@proxmox.com> References: <20240723152548.129832-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 01/10] code cleanup: drop unused parameter from get_vm_machine() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The parameter was added by ac0077cc ("Use 'QEMU version' -> '+pve-version' mapping for machine types") but it doesn't seem like there ever was a caller. In particular, none of the current callers pass in a value and it's not clear when one would require passing a different version than the KVM binary version. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index bf59b091..65784187 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3253,13 +3253,13 @@ sub windows_get_pinned_machine_version { } sub get_vm_machine { - my ($conf, $forcemachine, $arch, $add_pve_version, $kvmversion) = @_; + my ($conf, $forcemachine, $arch, $add_pve_version) = @_; my $machine_conf = PVE::QemuServer::Machine::parse_machine($conf->{machine}); my $machine = $forcemachine || $machine_conf->{type}; if (!$machine || $machine =~ m/^(?:pc|q35|virt)$/) { - $kvmversion //= kvm_user_version(); + my $kvmversion //= kvm_user_version(); # we must pin Windows VMs without a specific version to 5.1, as 5.2 fixed a bug in ACPI # layout which confuses windows quite a bit and may result in various regressions.. # see: https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg08484.html -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel