From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 2623F1FF2CA
	for <inbox@lore.proxmox.com>; Tue, 23 Jul 2024 17:26:06 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 9FE756A37;
	Tue, 23 Jul 2024 17:26:26 +0200 (CEST)
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Tue, 23 Jul 2024 17:25:38 +0200
Message-Id: <20240723152548.129832-1-f.ebner@proxmox.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.061 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [qemuserver.pm]
Subject: [pve-devel] [PATCH-SERIES qemu-server] cfg2cmd: bump minimum binary
 version to 5.0 and test for QEMU machine version instead of binary version
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Since there are certain checks that depend on the QEMU binary version,
tests with a fixed QEMU binary version make it less likely to catch
issues on current setups, because current setups will always have a
newer QEMU binary version than the test.

There are only three tests that explicitly want to test for the binary
version. All others are better of setting the appropriate machine
version they want to test for or just use the current machine version
if no version-specific feature is tested for.

The minimum binary version that can be used is bumped to 5.0 which was
used in Proxmox VE 6.2, to still allow for long-term regression
testing.

Split into bite-sized pieces for better reviewability.


Fiona Ebner (10):
  code cleanup: drop unused parameter from get_vm_machine()
  test: bump QEMU version in tests for too new machine type and pve
    version
  test: cfg2cmd: don't use QEMU binary version less than 4.0 for tests
  cfg2cmd: require at least QEMU binary version 4.0
  test: cfg2cmd: don't use QEMU binary version less than 5.0 for tests
  cfg2cmd: require at least QEMU binary version 5.0
  cfg2cmd: drop superfluous check for QEMU binary version 4.1
  test: cfg2cmd: don't use QEMU binary version less than 6.0 for tests
  test: cfg2cmd: don't use QEMU binary version less than 7.0 for tests
  test: cfg2cmd: don't use QEMU binary version less than 8.0 for tests

 PVE/QemuServer.pm                             | 26 +++++++------------
 test/cfg2cmd/bootorder-empty.conf             |  1 -
 test/cfg2cmd/bootorder-empty.conf.cmd         | 12 ++++-----
 test/cfg2cmd/bootorder-legacy.conf            |  1 -
 test/cfg2cmd/bootorder-legacy.conf.cmd        | 12 ++++-----
 test/cfg2cmd/bootorder.conf                   |  1 -
 test/cfg2cmd/bootorder.conf.cmd               | 12 ++++-----
 .../cputype-icelake-client-deprecation.conf   |  1 -
 test/cfg2cmd/memory-hotplug-hugepages.conf    |  3 +--
 .../cfg2cmd/memory-hotplug-hugepages.conf.cmd |  4 +--
 test/cfg2cmd/memory-hotplug.conf              |  1 -
 test/cfg2cmd/memory-hotplug.conf.cmd          |  4 +--
 test/cfg2cmd/memory-hugepages-1g.conf         |  3 +--
 test/cfg2cmd/memory-hugepages-1g.conf.cmd     |  4 +--
 test/cfg2cmd/memory-hugepages-2m.conf         |  3 +--
 test/cfg2cmd/memory-hugepages-2m.conf.cmd     |  4 +--
 .../minimal-defaults-to-new-machine.conf      |  4 +--
 ...imal-defaults-unsupported-pve-version.conf |  6 ++---
 test/cfg2cmd/netdev-7.0-multiqueues.conf      |  2 +-
 test/cfg2cmd/netdev-7.0-multiqueues.conf.cmd  |  2 +-
 test/cfg2cmd/netdev-7.1-multiqueues.conf      |  1 -
 test/cfg2cmd/netdev-7.1.conf                  |  1 -
 test/cfg2cmd/netdev.conf                      |  2 +-
 test/cfg2cmd/netdev.conf.cmd                  |  2 +-
 test/cfg2cmd/old-qemu.conf                    |  4 +--
 test/cfg2cmd/ostype-usb13-error.conf          |  1 -
 test/cfg2cmd/q35-simple-6.0.conf              |  3 +--
 test/cfg2cmd/q35-simple-6.0.conf.cmd          |  2 +-
 test/cfg2cmd/q35-simple-7.0.conf              |  3 +--
 test/cfg2cmd/q35-simple-7.0.conf.cmd          |  2 +-
 test/cfg2cmd/q35-usb13-error.conf             |  3 +--
 test/cfg2cmd/q35-usb2.conf                    |  3 +--
 test/cfg2cmd/q35-usb2.conf.cmd                |  2 +-
 test/cfg2cmd/q35-usb3.conf                    |  3 +--
 test/cfg2cmd/q35-usb3.conf.cmd                |  2 +-
 test/cfg2cmd/qemu-xhci-7.1.conf               |  2 +-
 test/cfg2cmd/qemu-xhci-7.1.conf.cmd           |  2 +-
 test/cfg2cmd/qemu-xhci-q35-7.1.conf           |  1 -
 .../simple-balloon-free-page-reporting.conf   |  2 +-
 ...imple-balloon-free-page-reporting.conf.cmd |  2 +-
 test/cfg2cmd/simple-btrfs.conf                |  1 -
 test/cfg2cmd/simple-btrfs.conf.cmd            |  4 +--
 test/cfg2cmd/simple-virtio-blk.conf           |  1 -
 test/cfg2cmd/simple-virtio-blk.conf.cmd       |  8 +++---
 test/cfg2cmd/simple1-template.conf            |  1 -
 test/cfg2cmd/simple1-template.conf.cmd        | 10 +++----
 test/cfg2cmd/simple1.conf                     |  1 -
 test/cfg2cmd/simple1.conf.cmd                 | 10 +++----
 test/cfg2cmd/spice-enhancments.conf           |  2 +-
 test/cfg2cmd/spice-enhancments.conf.cmd       |  2 +-
 test/cfg2cmd/spice-linux-4.1.conf             |  2 +-
 test/cfg2cmd/spice-linux-4.1.conf.cmd         |  2 +-
 test/cfg2cmd/spice-usb3.conf                  |  2 +-
 test/cfg2cmd/spice-usb3.conf.cmd              |  2 +-
 test/cfg2cmd/spice-win.conf                   |  2 +-
 test/cfg2cmd/spice-win.conf.cmd               |  2 +-
 test/cfg2cmd/usb13-error.conf                 |  2 +-
 57 files changed, 88 insertions(+), 115 deletions(-)

-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel