From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8D9081FF2CA for ; Tue, 23 Jul 2024 15:32:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 588A74401; Tue, 23 Jul 2024 15:33:17 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Tue, 23 Jul 2024 15:33:13 +0200 Message-Id: <20240723133313.383509-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240703080147.81154-1-a.lauterer@proxmox.com> References: <20240703080147.81154-1-a.lauterer@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit v3 7/6 follow-up] Network: add explanation for bridge vids field X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Make clear that it affects only out-/inbound traffic and can be used if the underlying physical NICs support only a limited number of VLANs when offloading is possible. Signed-off-by: Aaron Lauterer --- After some off-list discussion with @Stefan Hanreich after his review, we came to the conclusion that some explanation is needed to avoid confusion. I am not too happy with how long the explanation is, if someone has a better idea to transport that information, I am absolutely not opposed to it. src/node/NetworkEdit.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js index 8c1b135..1149dee 100644 --- a/src/node/NetworkEdit.js +++ b/src/node/NetworkEdit.js @@ -109,6 +109,12 @@ Ext.define('Proxmox.node.NetworkEdit', { return true; }, }); + let vidsExplanation = Ext.create('Ext.form.field.Display', { + disabled: true, + userCls: 'pmx-hint', + value: 'Use if you want the bridge ports to only forward a limited number of ' + + 'VLANs or the physical NICs support a limited number of offloaded VLANs.', + }); column2.push({ xtype: 'proxmoxcheckbox', fieldLabel: gettext('VLAN aware'), @@ -118,6 +124,7 @@ Ext.define('Proxmox.node.NetworkEdit', { change: function(f, newVal) { if (me.bridge_set_vids) { vids.setDisabled(!newVal); + vidsExplanation.setDisabled(!newVal); } }, }, @@ -133,6 +140,7 @@ Ext.define('Proxmox.node.NetworkEdit', { }); if (me.bridge_set_vids) { advancedColumn2.push(vids); + advancedColumn2.push(vidsExplanation); } } else if (me.iftype === 'OVSBridge') { column2.push({ -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel