From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4F2D11FF2C8 for ; Wed, 17 Jul 2024 11:41:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AC1DD381D1; Wed, 17 Jul 2024 11:41:33 +0200 (CEST) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Wed, 17 Jul 2024 11:40:03 +0200 Message-Id: <20240717094034.124857-6-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240717094034.124857-1-m.carrara@proxmox.com> References: <20240717094034.124857-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC pve-storage 05/36] plugin: cifs: make plugin-specific helpers private X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Max Carrara --- src/PVE/Storage/CIFSPlugin.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/Storage/CIFSPlugin.pm b/src/PVE/Storage/CIFSPlugin.pm index 2184471..18dc017 100644 --- a/src/PVE/Storage/CIFSPlugin.pm +++ b/src/PVE/Storage/CIFSPlugin.pm @@ -13,7 +13,7 @@ use base qw(PVE::Storage::Plugin); # CIFS helper functions -sub cifs_is_mounted : prototype($$) { +my sub cifs_is_mounted : prototype($$) { my ($scfg, $mountdata) = @_; my ($mountpoint, $server, $share) = $scfg->@{'path', 'server', 'share'}; @@ -31,12 +31,12 @@ sub cifs_is_mounted : prototype($$) { return undef; } -sub cifs_cred_file_name { +my sub cifs_cred_file_name { my ($storeid) = @_; return "/etc/pve/priv/storage/${storeid}.pw"; } -sub cifs_delete_credentials { +my sub cifs_delete_credentials { my ($storeid) = @_; if (my $cred_file = get_cred_file($storeid)) { @@ -44,7 +44,7 @@ sub cifs_delete_credentials { } } -sub cifs_set_credentials { +my sub cifs_set_credentials { my ($password, $storeid) = @_; my $cred_file = cifs_cred_file_name($storeid); @@ -55,7 +55,7 @@ sub cifs_set_credentials { return $cred_file; } -sub get_cred_file { +my sub get_cred_file { my ($storeid) = @_; my $cred_file = cifs_cred_file_name($storeid); @@ -66,7 +66,7 @@ sub get_cred_file { return undef; } -sub cifs_mount : prototype($$$$$) { +my sub cifs_mount : prototype($$$$$) { my ($scfg, $storeid, $smbver, $user, $domain) = @_; my ($mountpoint, $server, $share, $options) = $scfg->@{'path', 'server', 'share', 'options'}; -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel