From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CC21D1FF2C8 for ; Wed, 17 Jul 2024 11:44:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 65F4138E01; Wed, 17 Jul 2024 11:43:50 +0200 (CEST) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Wed, 17 Jul 2024 11:40:30 +0200 Message-Id: <20240717094034.124857-33-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240717094034.124857-1-m.carrara@proxmox.com> References: <20240717094034.124857-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC pve-storage 32/36] plugin: nfs: make helper subroutines private X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The `nfs_is_mounted` and `nfs_mount` subroutines are not part of any (official) public interface / API, nor are they used anywhere in our code, so make them private to prevent haphazard use. Signed-off-by: Max Carrara --- src/PVE/Storage/NFSPlugin.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Storage/NFSPlugin.pm b/src/PVE/Storage/NFSPlugin.pm index 0d02b49..6dbf8b4 100644 --- a/src/PVE/Storage/NFSPlugin.pm +++ b/src/PVE/Storage/NFSPlugin.pm @@ -23,7 +23,7 @@ use base qw(PVE::Storage::Plugin); # NFS helper functions -sub nfs_is_mounted { +my sub nfs_is_mounted { my ($server, $export, $mountpoint, $mountdata) = @_; $server = "[$server]" if Net::IP::ip_is_ipv6($server); @@ -38,7 +38,7 @@ sub nfs_is_mounted { return undef; } -sub nfs_mount { +my sub nfs_mount { my ($server, $export, $mountpoint, $options) = @_; $server = "[$server]" if Net::IP::ip_is_ipv6($server); -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel