From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2CFA31FF2C8 for ; Wed, 17 Jul 2024 11:43:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 22A2038D2D; Wed, 17 Jul 2024 11:43:45 +0200 (CEST) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Wed, 17 Jul 2024 11:40:29 +0200 Message-Id: <20240717094034.124857-32-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240717094034.124857-1-m.carrara@proxmox.com> References: <20240717094034.124857-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC pve-storage 31/36] plugin: lvmthin: update definition of subroutine `activate_lv` X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" .. so that it is not just an anonymous sub assigned to a reference, but a "proper" private subroutine instead. Also update its call sites correspondingly. Signed-off-by: Max Carrara --- src/PVE/Storage/LvmThinPlugin.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/Storage/LvmThinPlugin.pm b/src/PVE/Storage/LvmThinPlugin.pm index 1fcafdd..c89b382 100644 --- a/src/PVE/Storage/LvmThinPlugin.pm +++ b/src/PVE/Storage/LvmThinPlugin.pm @@ -204,7 +204,7 @@ sub status { ); } -my $activate_lv = sub { +my sub activate_lv { my ($vg, $lv, $cache) = @_; my $lvs = $cache->{lvs} ||= lvm_list_volumes(); @@ -225,7 +225,7 @@ sub activate_storage { $class->SUPER::activate_storage($storeid, $scfg, $cache); - $activate_lv->($scfg->{vgname}, $scfg->{thinpool}, $cache); + activate_lv($scfg->{vgname}, $scfg->{thinpool}, $cache); } sub activate_volume { @@ -234,7 +234,7 @@ sub activate_volume { my $vg = $scfg->{vgname}; my $lv = $snapname ? "snap_${volname}_$snapname" : $volname; - $activate_lv->($vg, $lv, $cache); + activate_lv($vg, $lv, $cache); } sub deactivate_volume { -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel