From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A631E1FF2C8 for ; Wed, 17 Jul 2024 11:43:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3C12438B00; Wed, 17 Jul 2024 11:43:10 +0200 (CEST) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Wed, 17 Jul 2024 11:40:28 +0200 Message-Id: <20240717094034.124857-31-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240717094034.124857-1-m.carrara@proxmox.com> References: <20240717094034.124857-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC pve-storage 30/36] plugin: lvm: update definition of subroutine `check_tags` X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" So it's not just an anonymous sub assigned to a reference, but a "proper" private subroutine instead. Also update its only call site correspondingly. Signed-off-by: Max Carrara --- src/PVE/Storage/LVMPlugin.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index a9bc178..df041aa 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -307,7 +307,7 @@ sub free_image { return undef; } -my $check_tags = sub { +my sub check_tags { my ($tags) = @_; return defined($tags) && $tags =~ /(^|,)pve-vm-\d+(,|$)/; @@ -331,7 +331,7 @@ sub list_images { my $info = $dat->{$volname}; - next if $scfg->{tagged_only} && !&$check_tags($info->{tags}); + next if $scfg->{tagged_only} && !check_tags($info->{tags}); # Allow mirrored and RAID LVs next if $info->{lv_type} !~ m/^[-mMrR]$/; -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel