From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E136B1FF2C8 for ; Wed, 17 Jul 2024 11:43:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 92CBD389EB; Wed, 17 Jul 2024 11:43:04 +0200 (CEST) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Wed, 17 Jul 2024 11:40:21 +0200 Message-Id: <20240717094034.124857-24-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240717094034.124857-1-m.carrara@proxmox.com> References: <20240717094034.124857-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC pve-storage 23/36] plugin: esxi: make helper subroutines private X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Max Carrara --- src/PVE/Storage/ESXiPlugin.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index a35693d..d4b6afc 100644 --- a/src/PVE/Storage/ESXiPlugin.pm +++ b/src/PVE/Storage/ESXiPlugin.pm @@ -59,12 +59,12 @@ sub options { }; } -sub esxi_cred_file_name { +my sub esxi_cred_file_name { my ($storeid) = @_; return "/etc/pve/priv/storage/${storeid}.pw"; } -sub esxi_delete_credentials { +my sub esxi_delete_credentials { my ($storeid) = @_; if (my $cred_file = get_cred_file($storeid)) { @@ -72,7 +72,7 @@ sub esxi_delete_credentials { } } -sub esxi_set_credentials { +my sub esxi_set_credentials { my ($password, $storeid) = @_; my $cred_file = esxi_cred_file_name($storeid); @@ -83,7 +83,7 @@ sub esxi_set_credentials { return $cred_file; } -sub get_cred_file { +my sub get_cred_file { my ($storeid) = @_; my $cred_file = esxi_cred_file_name($storeid); @@ -267,7 +267,7 @@ sub esxi_unmount : prototype($$$) { } # Split a path into (datacenter, datastore, path) -sub split_path : prototype($) { +my sub split_path : prototype($) { my ($path) = @_; if ($path =~ m!^([^/]+)/([^/]+)/(.+)$!) { return ($1, $2, $3); @@ -752,7 +752,7 @@ sub vmx_path { $_[0]->{'pve.vmx.path'} } sub manifest { $_[0]->{'pve.manifest'} } # (Also used for the fileName config key...) -sub is_disk_entry : prototype($) { +my sub is_disk_entry : prototype($) { my ($id) = @_; if ($id =~ /^(scsi|ide|sata|nvme)(\d+:\d+)(:?\.fileName)?$/) { return ($1, $2); -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel