From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2B58B1FF2C8 for ; Wed, 17 Jul 2024 11:40:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 63C3137DF8; Wed, 17 Jul 2024 11:40:43 +0200 (CEST) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Wed, 17 Jul 2024 11:39:59 +0200 Message-Id: <20240717094034.124857-2-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240717094034.124857-1-m.carrara@proxmox.com> References: <20240717094034.124857-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC pve-storage 01/36] plugin: base: remove old fixme comments X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" These have been around since 2012 - suffice to say they're not needed anymore. Signed-off-by: Max Carrara --- src/PVE/Storage/Plugin.pm | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 6444390..3219f1f 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -299,19 +299,6 @@ sub parse_lvm_name { return $name; } -# fixme: do we need this -#PVE::JSONSchema::register_format('pve-storage-portal', \&verify_portal); -#sub verify_portal { -# my ($portal, $noerr) = @_; -# -# # IP with optional port -# if ($portal !~ m/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}(:\d+)?$/) { -# return undef if $noerr; -# die "value does not look like a valid portal address\n"; -# } -# return $portal; -#} - PVE::JSONSchema::register_format('pve-storage-portal-dns', \&verify_portal_dns); sub verify_portal_dns { my ($portal, $noerr) = @_; @@ -457,12 +444,6 @@ sub decode_value { } } - # fixme: - # no node restrictions for local storage - #if ($storeid && $storeid eq 'local' && scalar(keys(%$res))) { - # die "storage '$storeid' does not allow node restrictions\n"; - #} - return $res; } elsif ($key eq 'content-dirs') { my $valid_content = $def->{content}->[0]; -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel