From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 455851FF2A0 for ; Mon, 15 Jul 2024 10:05:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3CB1E358EC; Mon, 15 Jul 2024 10:05:37 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Mon, 15 Jul 2024 09:56:02 +0200 Message-ID: <20240715075700.283532-3-c.heiss@proxmox.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240715075700.283532-1-c.heiss@proxmox.com> References: <20240715075700.283532-1-c.heiss@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer v2 2/6] tui-installer: remove `Debug` implementation for password options X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" So we never accidentally show/log the password somewhere. Need to drop it from `InstallerOptions` in turn too, but it's never used currently anyway. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes proxmox-tui-installer/src/options.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-tui-installer/src/options.rs b/proxmox-tui-installer/src/options.rs index 6335762..19992ca 100644 --- a/proxmox-tui-installer/src/options.rs +++ b/proxmox-tui-installer/src/options.rs @@ -24,7 +24,7 @@ pub const FS_TYPES: &[FsType] = { ] }; -#[derive(Clone, Debug)] +#[derive(Clone)] pub struct PasswordOptions { pub email: String, pub root_password: String, @@ -39,7 +39,7 @@ impl Default for PasswordOptions { } } -#[derive(Clone, Debug)] +#[derive(Clone)] pub struct InstallerOptions { pub bootdisk: BootdiskOptions, pub timezone: TimezoneOptions, -- 2.45.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel