From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id ED4261FF2C6 for ; Wed, 10 Jul 2024 15:28:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 97627A37E; Wed, 10 Jul 2024 15:28:20 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 10 Jul 2024 15:27:52 +0200 Message-ID: <20240710132756.1149508-14-c.heiss@proxmox.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240710132756.1149508-1-c.heiss@proxmox.com> References: <20240710132756.1149508-1-c.heiss@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer 13/14] fix #5536: post-hook: add some unit tests X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Christoph Heiss --- proxmox-post-hook/src/main.rs | 126 ++++++++++++++++++++++++++++++++++ 1 file changed, 126 insertions(+) diff --git a/proxmox-post-hook/src/main.rs b/proxmox-post-hook/src/main.rs index 9e5680b..dc25a79 100644 --- a/proxmox-post-hook/src/main.rs +++ b/proxmox-post-hook/src/main.rs @@ -370,3 +370,129 @@ fn main() -> ExitCode { } } } + +#[cfg(test)] +mod tests { + use crate::PostHookInfo; + use proxmox_installer_common::setup::{ProxmoxProduct, SetupInfo}; + + #[test] + fn dpkg_query_parsing_returns_correct_kernel() { + const OUTPUT: &str = r#" +ii |all|proxmox-kernel-6.8 + +un ||proxmox-kernel-6.8.8-2-pve +foobarinvalidentry +ii |amd64|proxmox-kernel-6.8.8-2-pve-signed + "#; + + assert_eq!( + PostHookInfo::parse_dpkg_query_kernel_output(OUTPUT, "amd64") + .as_deref() + .unwrap(), + "proxmox-kernel-6.8.8-2-pve-signed" + ); + } + + #[test] + fn dpkg_query_parsing_returns_error_on_invalid_arch() { + const OUTPUT: &str = r#" +ii |all|proxmox-kernel-6.8 + +un ||proxmox-kernel-6.8.8-2-pve +foobarinvalidentry +ii |amd64|proxmox-kernel-6.8.8-2-pve-signed + "#; + + assert_eq!( + PostHookInfo::parse_dpkg_query_kernel_output(OUTPUT, "arm64") + .as_deref() + .unwrap_err() + .to_string(), + "failed to find kernel package" + ); + } + + #[test] + fn correctly_parses_pveversion_output() { + const OUTPUT: &str = "pve-manager/8.2.4/faa83925c9641325 (running kernel: 6.8.8-2-pve)\n"; + + assert_eq!( + PostHookInfo::gather_product_version(&SetupInfo::mocked(), &|_| Ok(OUTPUT.to_owned())) + .as_deref() + .unwrap(), + "pve-manager/8.2.4/faa83925c9641325" + ); + } + + #[test] + fn fails_to_parse_invalid_pveversion_output() { + assert_eq!( + PostHookInfo::gather_product_version(&SetupInfo::mocked(), &|_| Ok("".to_owned())) + .as_deref() + .unwrap_err() + .to_string(), + "failed to parse `pveversion` output" + ); + + assert_eq!( + PostHookInfo::gather_product_version(&SetupInfo::mocked(), &|_| Ok( + "invalid".to_owned() + )) + .as_deref() + .unwrap_err() + .to_string(), + "failed to parse `pveversion` output" + ); + } + + #[test] + fn correctly_parses_pmgversion_output() { + const OUTPUT: &str = "pmg-api/8.1.2/fd71566ae016 (running kernel: 6.8.8-1-pve)\n"; + + let mut setup_info = SetupInfo::mocked(); + setup_info.config.product = ProxmoxProduct::PMG; + assert_eq!( + PostHookInfo::gather_product_version(&setup_info, &|_| Ok(OUTPUT.to_owned())) + .as_deref() + .unwrap(), + "pmg-api/8.1.2/fd71566ae016" + ); + } + + #[test] + fn correctly_parses_proxmox_backup_manager_version_output() { + const OUTPUT: &str = r#"[{"Arch":"amd64","Description":"Proxmox Backup Server daemon with tools and GUI\n This package contains the Proxmox Backup Server daemons and related\n tools. This includes a web-based graphical user interface.","ExtraInfo":"running version: 3.2.7","OldVersion":"3.2.7-1","Origin":"Proxmox","Package":"proxmox-backup-server","Priority":"optional","Section":"admin","Title":"Proxmox Backup Server daemon with tools and GUI","Version":"3.2.7-1"}]"#; + + let mut setup_info = SetupInfo::mocked(); + setup_info.config.product = ProxmoxProduct::PBS; + + assert_eq!( + PostHookInfo::gather_product_version(&setup_info, &|_| Ok(OUTPUT.to_owned())) + .as_deref() + .unwrap(), + "proxmox-backup-server/3.2.7-1" + ); + } + + #[test] + fn fails_to_parse_invalid_proxmox_backup_manager_version_output() { + let mut setup_info = SetupInfo::mocked(); + setup_info.config.product = ProxmoxProduct::PBS; + + assert_eq!( + PostHookInfo::gather_product_version(&setup_info, &|_| Ok("".to_owned())) + .as_deref() + .unwrap_err() + .to_string(), + "failed to parse json output from 'proxmox-backup-manager'" + ); + assert_eq!( + PostHookInfo::gather_product_version(&setup_info, &|_| Ok("invalid".to_owned())) + .as_deref() + .unwrap_err() + .to_string(), + "failed to parse json output from 'proxmox-backup-manager'" + ); + } +} -- 2.45.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel