From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0E7221FF2C6 for ; Wed, 10 Jul 2024 14:42:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 00ED49528; Wed, 10 Jul 2024 14:43:04 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Wed, 10 Jul 2024 14:42:58 +0200 Message-Id: <20240710124300.295817-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mds.pm, ceph.com] Subject: [pve-devel] [PATCH manager 0/2] fix #5570 ceph mds: allow custom MDS IDs from the UI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The ID for the MDS cannot start with a number [0]. The first patch adds a check for this. The second patch is the actual fix, by reworking the edit window when adding new MDS'. By allowing the users to set the name of the MDS directly, we can catch the situation where the hostname starts with a number and let the user decide how it should be named. Similar to what they can already do on the CLI. Another approach would be to leave the UI as is and catch the situation in the backend. If an ID that starts with a number is detected, we could prepend it with a default string. [0] https://docs.ceph.com/en/latest/man/8/ceph-mds/ Aaron Lauterer (2): api: ceph mds: avoid creating MDS when ID starts with number fix#5570 ui: ceph: make MDS ID configurable PVE/API2/Ceph/MDS.pm | 2 ++ www/manager6/ceph/ServiceList.js | 21 +++++++++++---------- 2 files changed, 13 insertions(+), 10 deletions(-) -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel