From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 26D9A1FF2C6 for ; Tue, 9 Jul 2024 12:51:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EFA4B1DBB7; Tue, 9 Jul 2024 12:51:30 +0200 (CEST) Date: Tue, 9 Jul 2024 12:50:54 +0200 From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Message-ID: <20240709125054.204c2f4b@rosa.proxmox.com> In-Reply-To: <20240624195712.962468-1-s.ivanov@proxmox.com> References: <20240624195712.962468-1-s.ivanov@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-offline-mirror 0/2] remove snapshot directories vanished on source also on medium X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" superseded-by: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064545.html On Mon, 24 Jun 2024 21:57:10 +0200 Stoiko Ivanov wrote: > This patchset fixes a small glitch that we noticed in a pom-setup, creating > regular snapshots, without cleaning them up regularly. > > Eventually medium sync becomes quite slow. > After removing many snapshots and running garbage collection both on the > mirror as well as on the medium the run-time for the sync still took quite > long. strace showed that the process still walked through the directories > for each snapshot on the medium - they were not cleaned up after all the > files inside were removed. > > tested the patch locally (which is the reason for patch 1/2). > > Stoiko Ivanov (2): > bump proxmox-time to 2.0 > medium: remove snapshot link directories not present in source mirror > > Cargo.toml | 2 +- > debian/control | 2 +- > src/medium.rs | 18 +++++++++++++++++- > src/types.rs | 2 +- > 4 files changed, 20 insertions(+), 4 deletions(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel