From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DFBB01FF2C6 for ; Tue, 9 Jul 2024 13:50:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 891FB1EB37; Tue, 9 Jul 2024 13:51:19 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Tue, 9 Jul 2024 13:51:16 +0200 Message-Id: <20240709115116.333708-2-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240709115116.333708-1-m.sandoval@proxmox.com> References: <20240709115116.333708-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.120 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence Subject: [pve-devel] [PATCH storage 2/2] btrfs: forcefully set image to readwrite X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" When a subvolume is transferred via btrfs send/receive the resulting image contains the received_uuid property set. This property is required to do incremental snapshots. A downside though is that once the received_uuid property is set, it is not possible to make the image readwrite again without the force (-f) flag, and in such case the received_uuid property is lost. Since we know the images are only set to rw for the duration of the move, it is safe to set the flag forcefully and then in a future commit add the received_uuid proprty by force. Signed-off-by: Maximiliano Sandoval --- src/PVE/Storage/BTRFSPlugin.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.pm index dc0420d..9a9dd51 100644 --- a/src/PVE/Storage/BTRFSPlugin.pm +++ b/src/PVE/Storage/BTRFSPlugin.pm @@ -870,7 +870,7 @@ sub volume_import { # Rotate the disk into place, first the current state: # Note that read-only subvolumes cannot be moved into different directories, but for the # "current" state we also want a writable copy, so start with that: - $class->btrfs_cmd(['property', 'set', "$tmppath/$diskname\@$snapshot", 'ro', 'false']); + $class->btrfs_cmd(['property', 'set', '-f', "$tmppath/$diskname\@$snapshot", 'ro', 'false']); PVE::Tools::renameat2( -1, "$tmppath/$diskname\@$snapshot", @@ -892,7 +892,7 @@ sub volume_import { # Now go through the remaining snapshots (if any) foreach my $snap (@snapshots) { - $class->btrfs_cmd(['property', 'set', "$tmppath/$diskname\@$snap", 'ro', 'false']); + $class->btrfs_cmd(['property', 'set', '-f', "$tmppath/$diskname\@$snap", 'ro', 'false']); PVE::Tools::renameat2( -1, "$tmppath/$diskname\@$snap", -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel