From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 784911FF2C6 for ; Tue, 9 Jul 2024 12:47:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 870B71D709; Tue, 9 Jul 2024 12:47:26 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 9 Jul 2024 12:47:02 +0200 Message-Id: <20240709104705.1681395-3-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240709104705.1681395-1-s.ivanov@proxmox.com> References: <20240709104705.1681395-1-s.ivanov@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pool.rs] Subject: [pve-devel] [PATCH proxmox-offline-mirror v2 2/5] pool: drop superfluous check for impossible path combination X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" commit c598cb154ef3fa6e1a8af840ded40f713d973d3d changed the pool layout to have the pool directory (.pool for a mirror) on the same level as the link directory (instead of below), to enable pool-sharing across multiple mirrors. the condition will never be true, drop the if statement to avoid confusion in the future. Signed-off-by: Stoiko Ivanov --- src/pool.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/pool.rs b/src/pool.rs index f20f5ea..611dcc9 100644 --- a/src/pool.rs +++ b/src/pool.rs @@ -265,9 +265,6 @@ impl PoolLockGuard<'_> { for link_entry in WalkDir::new(&self.pool.link_dir).into_iter() { let path = link_entry?.into_path(); - if self.path_in_pool(&path) { - continue; - }; let meta = path.metadata()?; if !meta.is_file() { -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel