From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 02D941FF2AD for ; Thu, 4 Jul 2024 15:36:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9BB3335AC; Thu, 4 Jul 2024 15:36:54 +0200 (CEST) Date: Thu, 4 Jul 2024 15:36:21 +0200 From: Gabriel Goller To: Proxmox VE development discussion Message-ID: <20240704133621.o2upi4jf7dduvd3b@luna.proxmox.com> References: <20240704123648.268894-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240704123648.268894-1-s.hanreich@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-firewall v2 1/1] service: flush firewall rules on force disable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 04.07.2024 14:36, Stefan Hanreich wrote: >When disabling the nftables firewall again, there is a race condition >where the nftables ruleset never gets flushed and persists after >disabling. > >The nftables firewall update loop does a noop when the force disable >file exists. It only flushes the ruleset when nftables is disabled in >the configuration file but the force disable file does not yet exist. > >This can lead to the following situation: > >* nftables is activated and created its ruleset >* user switches from nftables firewall back to iptables firewall >* pve-firewall runs and creates the force disable file >* proxmox-firewall sees that the file exists and does nothing > >Reported-by: Hannes Laimer >Signed-off-by: Stefan Hanreich >--- >Changes from v1 to v2: >* Removed misleading/wrong section about the probability of this > happening >* Added a detailed description of the scenario this commit prevents > > proxmox-firewall/src/bin/proxmox-firewall.rs | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/proxmox-firewall/src/bin/proxmox-firewall.rs b/proxmox-firewall/src/bin/proxmox-firewall.rs >index f7e816e..5133cbf 100644 >--- a/proxmox-firewall/src/bin/proxmox-firewall.rs >+++ b/proxmox-firewall/src/bin/proxmox-firewall.rs >@@ -91,6 +91,10 @@ fn main() -> Result<(), std::io::Error> { > > while !term.load(Ordering::Relaxed) { > if force_disable_flag.exists() { >+ if let Err(error) = remove_firewall() { >+ log::error!("unable to disable firewall: {error:#}"); Note that `std::io::Error` does not handle pretty-printing any different in `Display`. So this outputs the same as '{error}'. To also print the `ErrorKind` use either '{error:?}' or '{error:#?}', which produce: Custom { kind: NotFound, error: "cool" } or Custom { kind: NotFound, error: "cool", } >+ } >+ > std::thread::sleep(Duration::from_secs(5)); > continue; > } >-- >2.39.2 > > >_______________________________________________ >pve-devel mailing list >pve-devel@lists.proxmox.com >https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel