From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 446F01FF2A7 for ; Mon, 1 Jul 2024 16:11:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04BB83706D; Mon, 1 Jul 2024 16:11:15 +0200 (CEST) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Mon, 1 Jul 2024 16:10:30 +0200 Message-Id: <20240701141040.643701-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 pve-manager 00/10] Ceph Build Commit in UI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Lukas Wagner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Ceph Build Commit in UI - Version 2 =================================== Notable Changes since v1 ------------------------ * Use camelCase instead of snake_case for new functions / variables as per our style guide [0] (thanks Lukas!) * Refrain from using `const` for things that aren't actual constants as per our style guide [1] (thanks Lukas!) * NEW: Patch 09: Increase the default width of the version field in the OSD tree so that longer strings are immediately readable without needing to adjust the column widths manually --> e.g. "18.2.2 (e9fe820e7 -> 69ce99eba)" takes up a lot of space in the column * NEW: Patch 10: Include Ceph build commit in the version string which is part of the object of the `ceph/osd/{osdid}/metadata` call For a detailed list of changes, please see the comments in the individual patches. NOTE: I added Lukas's T-b and R-b tags to all patches except the new ones, as mentioned in a reply to v1 [2]. Older Versions -------------- v1: https://lists.proxmox.com/pipermail/pve-devel/2024-April/063772.html References ---------- [0]: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Casing [1]: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Variables [2]: https://lists.proxmox.com/pipermail/pve-devel/2024-June/064084.html Summary of Changes ------------------ Max Carrara (10): ceph: tools: refactor installation check as guard clause ceph: tools: parse Ceph version in separate sub and update regex ceph: services: remove old cluster broadcast ceph: services: refactor version existence check as guard clause utils: align regex of parse_ceph_version with Perl equivalent ui: ceph: services: parse and display build commit api: ceph: add build commit of host to Ceph osd index endpoint data ui: ceph: osd: rework rendering of version field & show build commit ui: ceph: osd: increase width of version column api: ceph: change version format in OSD metadata endpoint PVE/API2/Ceph/OSD.pm | 9 ++++- PVE/Ceph/Services.pm | 38 ++++++++++---------- PVE/Ceph/Tools.pm | 59 ++++++++++++++++++++++---------- www/manager6/Utils.js | 17 ++++++++- www/manager6/ceph/OSD.js | 57 +++++++++++++++++++++++++----- www/manager6/ceph/ServiceList.js | 32 +++++++++++++---- www/manager6/ceph/Services.js | 14 +++++++- 7 files changed, 170 insertions(+), 56 deletions(-) -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel