From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2EAE01FF3A0 for ; Thu, 13 Jun 2024 13:52:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 109931F821; Thu, 13 Jun 2024 13:53:27 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 13 Jun 2024 13:53:09 +0200 Message-ID: <20240613115318.842583-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.44.1 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer 0/4] tui: make disk options view tabbed on small screens X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This adds a tabbed view component, for usage in the advanced disk options dialog when selecting ZFS or Btrfs. Works pretty much the same as its GUI counterpart, as much as that is possible. It's currently only activated for small (<=80 columns) displays, to make disk selection a lot more usable in these cases. This mostly affects serial console installation, but possibly also installations using a virtual screen via IPMI/BMC. Testing can be done using the `stty` to set specific terminal sizes, e.g. `stty columns 80 rows 24` for a standard VT100-spec terminal. This componont/view may also be made the default for the advanced disk options dialog, to align the TUI with it GUI in more cases - I'm open for discussion on that. Would also simplify the code a lot, so there are certainly other benefits to it as well. Christoph Heiss (4): tui: fix some comment typos tui: bootdisk: align btrfs dialog interface with zfs equivalent tui: views: add new TabbedView component tui: bootdisk: use tabbed view for disk options on small screens proxmox-tui-installer/src/views/bootdisk.rs | 260 +++++++++++------- proxmox-tui-installer/src/views/mod.rs | 3 + .../src/views/tabbed_view.rs | 196 +++++++++++++ 3 files changed, 358 insertions(+), 101 deletions(-) create mode 100644 proxmox-tui-installer/src/views/tabbed_view.rs -- 2.44.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel