From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BE8651FF39E for ; Mon, 10 Jun 2024 14:59:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 84F4E1751A; Mon, 10 Jun 2024 15:00:19 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 10 Jun 2024 14:59:39 +0200 Message-Id: <20240610125942.116985-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240610125942.116985-1-f.ebner@proxmox.com> References: <20240610125942.116985-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [RFC qemu 4/7] block/backup: make cbw error also fail backup that does not use fleecing X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" If the backup target can't be reached or is very slow, then the default behavior for QEMU backup is to break the guest write. While an option to change this was introduced with the 'on-cbw-error' option for the copy-before-write filter, it only took an effect in combination with a snapshot-access node like is used for backup fleecing. In preparation to set the 'on-cbw-error' option for PVE backups that do not use fleecing. Unfortunately, the name for the option is "break-snapshot", but in the non-fleecing case, there is no snapshot-access node involved, so it's a bit of a misnomer. Signed-off-by: Fiona Ebner --- block/backup.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/backup.c b/block/backup.c index 82fedf1680..ba153110d3 100644 --- a/block/backup.c +++ b/block/backup.c @@ -202,6 +202,9 @@ static int coroutine_fn backup_loop(BackupBlockJob *job) out: block_copy_call_free(s); job->bg_bcs_call = NULL; + if (!ret) { + ret = bdrv_cbw_snapshot_error(job->cbw); + } return ret; } -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel