From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B66C61FF396 for ; Thu, 6 Jun 2024 11:22:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F19F3AFBD; Thu, 6 Jun 2024 11:22:54 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 6 Jun 2024 11:22:11 +0200 Message-Id: <20240606092220.1190913-17-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240606092220.1190913-1-d.csapak@proxmox.com> References: <20240606092220.1190913-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH qemu-server v4 10/12] api: include not mapped resources for running vms in migrate preconditions X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" so that we can show a proper warning in the migrate dialog and check it in the bulk migrate precondition check the unavailable_storages and should be the same as before, but we now always return (not_)allowed_nodes too. to make the code a bit easier to read, reorganize how we construct the (not_)allowed_nodes properties. also add a note that we want to redesign the return values here, to make * the api call simpler * return better structured values Signed-off-by: Dominik Csapak --- changes from v3: * rework the code a bit so it's easier to read and follow * properly fill allowed nodes now in the running case too PVE/API2/Qemu.pm | 45 ++++++++++++++++++++++++++------------------- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 24b82c6e..0a999006 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -4450,18 +4450,20 @@ __PACKAGE__->register_method({ }, }, returns => { + # TODO 9.x: rework the api call to return more sensible structures + # e.g. a simple list of nodes with their blockers and/or notices to show type => "object", properties => { running => { type => 'boolean' }, allowed_nodes => { type => 'array', optional => 1, - description => "List nodes allowed for offline migration, only passed if VM is offline" + description => "List nodes allowed for migration.", }, not_allowed_nodes => { type => 'object', optional => 1, - description => "List not allowed nodes with additional informations, only passed if VM is offline" + description => "List not allowed nodes with additional information.", }, local_disks => { type => 'array', @@ -4510,7 +4512,6 @@ __PACKAGE__->register_method({ my ($local_resources, $mapped_resources, $missing_mappings_by_node) = PVE::QemuServer::check_local_resources($vmconf, 1); - delete $missing_mappings_by_node->{$localnode}; my $vga = PVE::QemuServer::parse_vga($vmconf->{vga}); if ($res->{running} && $vga->{'clipboard'} && $vga->{'clipboard'} eq 'vnc') { @@ -4519,28 +4520,34 @@ __PACKAGE__->register_method({ # if vm is not running, return target nodes where local storage/mapped devices are available # for offline migration - if (!$res->{running}) { - $res->{allowed_nodes} = []; - my $checked_nodes = PVE::QemuServer::check_local_storage_availability($vmconf, $storecfg); - delete $checked_nodes->{$localnode}; - - foreach my $node (keys %$checked_nodes) { - my $missing_mappings = $missing_mappings_by_node->{$node}; - if (scalar($missing_mappings->@*)) { - $checked_nodes->{$node}->{'unavailable-resources'} = $missing_mappings; - next; - } + $res->{allowed_nodes} = []; + $res->{not_allowed_nodes} = {}; - if (!defined($checked_nodes->{$node}->{unavailable_storages})) { - push @{$res->{allowed_nodes}}, $node; - } + my $storage_nodehash = PVE::QemuServer::check_local_storage_availability($vmconf, $storecfg); + + my $nodelist = PVE::Cluster::get_nodelist(); + for my $node ($nodelist->@*) { + next if $node eq $localnode; + + # extract missing storage info + if (my $storage_info = $storage_nodehash->{$node}) { + $res->{not_allowed_nodes}->{$node} = $storage_info; + } + + # extract missing mappings info + my $missing_mappings = $missing_mappings_by_node->{$node}; + if (scalar($missing_mappings->@*)) { + $res->{not_allowed_nodes}->{$node}->{'unavailable-resources'} = $missing_mappings; + } + # if nothing came up, add it to the allowed nodes + if (!$res->{not_allowed_nodes}->{$node}) { + push $res->{allowed_nodes}->@*, $node; } - $res->{not_allowed_nodes} = $checked_nodes; } my $local_disks = &$check_vm_disks_local($storecfg, $vmconf, $vmid); - $res->{local_disks} = [ values %$local_disks ];; + $res->{local_disks} = [ values %$local_disks ]; $res->{local_resources} = $local_resources; $res->{'mapped-resources'} = [ sort keys $mapped_resources->%* ]; -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel