From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E578A1FF38C for ; Fri, 31 May 2024 12:08:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E079B32E36; Fri, 31 May 2024 12:08:30 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 31 May 2024 12:07:52 +0200 Message-Id: <20240531100753.40964-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: [pve-devel] [PATCH container] backup: warn that tar does not honor exclusion pattern with a trailing slash X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" As reported in the community forum [0], for tar, an exclusion pattern with a trailing slash will not match a folder with that name. For rsync and proxmox-backup-client however, such a pattern will exclude a directory with that name, but not a file. rsync is used for 'suspend' mode backup and tar is used for all non-PBS backups to create the archive. So currently, in the presence of an exclusion pattern with a trailing slash, there is inconsistency between different backup modes (because for 'suspend' mode, rsync will already do the exclusion too) as well as between PBS and non-PBS backups. There doesn't seem to be a straight-forward way to align the behavior for tar with command-line options exactly. The trailing slash can't be removed from the pattern, because that would also match files. Matching with > some/pattern/* > some/pattern/.* rather than > some/pattern/ gets pretty close, which was suggested by Dominik. Just the empty directory is still included. In any case, modifying current behavior would be a breaking change, so actually aligning the exclusion (more closely) is better done in the next major release. Signed-off-by: Fiona Ebner --- One could argue such a change is a bug-fix and so does not need to wait until the next major release. I opted for the safer variant for now, but happy to go with the aligning already if that is preferred. src/PVE/VZDump/LXC.pm | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm index 8c28a5e..914ede2 100644 --- a/src/PVE/VZDump/LXC.pm +++ b/src/PVE/VZDump/LXC.pm @@ -442,7 +442,16 @@ sub archive { } else { push @findexcl_anchored, $pattern; } - } + + # NOTE rsync and proxmox-backup-client will match directories, but not files when there + # is a trailing slash, tar won't match either. For suspend mode, rsync already did the + # exclusion, so no need to warn. + # TODO PVE 9 - consider matching "$pattern*" and "$pattern.*" in this case, which will + # only include the empty directory to more closely align the behavior between different + # modes. Don't forget to update the docs! + $self->log("warn", "tar does not match exclusion with a trailing slash '$pattern'") + if $pattern =~ m|/$| && $task->{mode} ne 'suspend'; + } push @$tar, '--no-anchored'; push @$tar, '--exclude=lost+found' if $userns_cmd; -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel