From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id ADAAA1FF38C for ; Fri, 31 May 2024 10:07:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 84C96311B1; Fri, 31 May 2024 10:07:38 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 31 May 2024 10:07:03 +0200 Message-Id: <20240531080703.880174-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cluster.pm, proxmox.com] Subject: [pve-devel] [RFC PATCH manager] api/ui: include the node ha status in resources call and show as icon X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" we already have the information parsed, so it's cheap, and we already have a mechanism in place that adds 'ha-' as a css class, so let's reuse that. I chose a yellow wrench, as wrenches are associated with 'maintenance', and because the state warrants more notice than 'online' but less than 'offline'. Users mentioned in the forum that this would be nice: https://forum.proxmox.com/threads/125768/ Signed-off-by: Dominik Csapak --- not sure about the color, since the yellow has relatively low contrast in the light mode (in dark mode it's fine). It's the same yellow as for 'io-errors' though. PVE/API2/Cluster.pm | 3 +++ www/css/ext6-pve.css | 8 ++++++++ 2 files changed, 11 insertions(+) diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm index 04387ab4..4fc838be 100644 --- a/PVE/API2/Cluster.pm +++ b/PVE/API2/Cluster.pm @@ -463,6 +463,9 @@ __PACKAGE__->register_method({ if (defined(my $mode = $info->{'cgroup-mode'})) { $entry->{'cgroup-mode'} = int($mode); } + if (defined(my $status = $hastatus->{node_status}->{$node})) { + $entry->{'hastate'} = $status; + } push @$res, $entry; } diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css index b5a3683a..83580afb 100644 --- a/www/css/ext6-pve.css +++ b/www/css/ext6-pve.css @@ -206,6 +206,14 @@ font-size: 0.75em; } +/* yellow wrench */ +.x-tree-icon-custom.ha-maintenance:after, +.x-grid-icon-custom.ha-maintenance:after { + content: "\f0ad"; + color: #FFCC00; +} + + /* yellow ! triangle */ .x-tree-icon-custom.pending:after, .x-grid-icon-custom.pending:after, -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel