From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 55BC11FF398 for ; Mon, 13 May 2024 14:14:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7CECF14DC4; Mon, 13 May 2024 14:14:09 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Mon, 13 May 2024 14:13:51 +0200 Message-ID: <20240513121357.1270503-3-c.heiss@proxmox.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240513121357.1270503-1-c.heiss@proxmox.com> References: <20240513121357.1270503-1-c.heiss@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer 2/6] fix #5250: install: write btrfs `compress` option to fstab X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" `compress` instead of `compress-force` is used, as the latter can have unindented (performance) implications, as the name implies. That would be neither expected by users nor should such a decision made without the user explicitly opting for it. Others do the same, e.g. the installer for RedHat/Fedora systems (aka. Anaconda) opts for `compress` also. And if Fedora uses it for their systems, it's fine for us too. Signed-off-by: Christoph Heiss --- Proxmox/Install.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index c0f8955..f3bc5aa 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -1011,7 +1011,13 @@ sub extract_data { die "unable to detect FS UUID" if !defined($fsuuid); - $fstab .= "UUID=$fsuuid / btrfs defaults 0 1\n"; + my $btrfs_opts = Proxmox::Install::Config::get_btrfs_opt(); + + my $mountopts = 'defaults'; + $mountopts .= ",compress=$btrfs_opts->{compress}" + if $btrfs_opts->{compress} ne 'off'; + + $fstab .= "UUID=$fsuuid / btrfs $mountopts 0 1\n"; } else { my $root_mountopt = $fssetup->{$filesys}->{root_mountopt} || 'defaults'; $fstab .= "$rootdev / $filesys ${root_mountopt} 0 1\n"; -- 2.44.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel