From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BD25B1FF390 for ; Fri, 10 May 2024 15:56:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E66C51EAC3; Fri, 10 May 2024 15:57:01 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 10 May 2024 15:56:58 +0200 Message-Id: <20240510135658.3519714-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240510135658.3519714-1-d.csapak@proxmox.com> References: <20240510135658.3519714-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [esxiplugin.pm] Subject: [pve-devel] [PATCH storage v2 1/1] esxi: improve error handling for fuse mount tool X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" if the fuse tool encounters an error early, it prints it like: Error: some error message on stderr. Redirect STDERR of the child process (which mounts the ESXi instance) to the pipe of the parent (API) process, so that it can pass a hopefully more meaningful message to the user than just an erroneous return code. Signed-off-by: Dominik Csapak --- src/PVE/Storage/ESXiPlugin.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index b8bce0e..4bcd7ff 100644 --- a/src/PVE/Storage/ESXiPlugin.pm +++ b/src/PVE/Storage/ESXiPlugin.pm @@ -222,6 +222,9 @@ sub esxi_mount : prototype($$$;$) { // die "failed to get file descriptor flags: $!\n"; fcntl($wr, F_SETFD, $flags & ~FD_CLOEXEC) // die "failed to remove CLOEXEC flag from fd: $!\n"; + + open(STDERR, ">&", $wr) or die "unable to redirect STDERR: $!\n"; + # FIXME: use the user/group options! exec {$ESXI_FUSE_TOOL} $ESXI_FUSE_TOOL, @@ -245,7 +248,7 @@ sub esxi_mount : prototype($$$;$) { undef $wr; my $result = do { local $/ = undef; <$rd> }; - if ($result =~ /^ERROR: (.*)$/) { + if ($result =~ /^ERROR: (.*)$/i) { die "$1\n"; } -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel