From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A4CD51FF38E for ; Wed, 8 May 2024 14:54:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4B4591FD4D; Wed, 8 May 2024 14:54:22 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 8 May 2024 14:54:18 +0200 Message-Id: <20240508125418.2598112-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [RFC PATCH manager] ui: make label for mediated device types more clear X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" 'MDev' could be interpreted as either 'Mediated Device' or 'Mapped Device', which can confuse users. At least one user was confused: https://forum.proxmox.com/threads/146586/#post-662091 Fix that by writing out 'Mediated Device'. Signed-off-by: Dominik Csapak --- sending as RFC because the text is now too long for one line, which is bad IMHO, but I could not come up with a better text that fits, maybe someone else has a better idea (or we leave it as is) www/manager6/qemu/PCIEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js index 8cef1b10..940e017c 100644 --- a/www/manager6/qemu/PCIEdit.js +++ b/www/manager6/qemu/PCIEdit.js @@ -262,7 +262,7 @@ Ext.define('PVE.qemu.PCIInputPanel', { name: 'mdev', reference: 'mdev', disabled: true, - fieldLabel: gettext('MDev Type'), + fieldLabel: gettext('Mediated Device Type'), nodename: me.nodename, listeners: { change: function(field, value) { -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel