From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8F48D20EC91 for ; Tue, 30 Apr 2024 17:18:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8FB0264; Tue, 30 Apr 2024 17:19:01 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 30 Apr 2024 17:18:47 +0200 Message-Id: <20240430151847.568829-3-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240430151847.568829-1-s.ivanov@proxmox.com> References: <20240430151847.568829-1-s.ivanov@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [parse-fqdn.pl] Subject: [pve-devel] [PATCH installer 2/2] tests: prevent uninitialized value warning with undef as fqdn X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" cosmetic issue - but was distracting enough to make me look if there's an error. Signed-off-by: Stoiko Ivanov --- test/parse-fqdn.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/parse-fqdn.pl b/test/parse-fqdn.pl index 6638fbe..47e0e21 100755 --- a/test/parse-fqdn.pl +++ b/test/parse-fqdn.pl @@ -24,9 +24,10 @@ sub is_parsed { sub is_invalid { my ($fqdn, $expected_err) = @_; + my $print_fqdn = $fqdn // '(undefined)'; my $parsed = eval { parse_fqdn($fqdn) }; - is($parsed, undef, "invalid FQDN did fail parsing: $fqdn"); - is($@, $expected_err, "invalid FQDN threw correct error: $fqdn"); + is($parsed, undef, "invalid FQDN did fail parsing: $print_fqdn"); + is($@, $expected_err, "invalid FQDN threw correct error: $print_fqdn"); } is_invalid(undef, ERR_EMPTY); -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel