From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2D92F20EC95 for ; Mon, 29 Apr 2024 13:23:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 65D8DE198; Mon, 29 Apr 2024 13:22:07 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 29 Apr 2024 13:21:20 +0200 Message-Id: <20240429112124.3819357-20-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240429112124.3819357-1-d.csapak@proxmox.com> References: <20240429112124.3819357-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v3 5/9] ui: disable 'import' button for non importable formats X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" importable formats are currently ova/ovf/vmx Signed-off-by: Dominik Csapak --- www/manager6/storage/Browser.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js index 934ce706..822257e7 100644 --- a/www/manager6/storage/Browser.js +++ b/www/manager6/storage/Browser.js @@ -124,6 +124,7 @@ Ext.define('PVE.storage.Browser', { }); } if (contents.includes('import')) { + let isImportable = format => ['ova', 'ovf', 'vmx'].indexOf(format) !== -1; let createGuestImportWindow = (selection) => { if (!selection) { return; @@ -149,13 +150,18 @@ Ext.define('PVE.storage.Browser', { enableUploadButton: enableUpload && !isEsxi, enableDownloadUrlButton: enableDownloadUrl && !isEsxi, useUploadButton: !isEsxi, - itemdblclick: (view, record) => createGuestImportWindow(record), + itemdblclick: (view, record) => { + if (isImportable(record.data.format)) { + createGuestImportWindow(record); + } + }, tbar: [ { xtype: 'proxmoxButton', disabled: true, text: gettext('Import'), iconCls: 'fa fa-cloud-download', + enableFn: rec => isImportable(rec.data.format), handler: function() { let grid = this.up('pveStorageContentView'); let selection = grid.getSelection()?.[0]; -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel